♻️ Split daemon process lifecycle helpers#267
Merged
Conversation
Why: isolate PID discovery and process-exit waiting from command orchestration so daemon lifecycle behavior is easier to test and reason about without touching start/stop UX paths. What changed: moved pid-file parsing, lsof discovery, pid resolution, and wait-for-exit helpers into src/commands/tdd-daemon-process.js and re-exported them from tdd-daemon.js for compatibility.
Vizzly - Visual Test ResultsCLI Reporter - 1 change needs review
Changes needing review (1)fullscreen-viewer · Firefox · 375×667 · 78.5% diff
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
tdd-daemonis a high-risk lifecycle surface. This PR takes one focused slice: process and PID lifecycle helpers.By extracting those helpers from command orchestration, we keep start/stop UX behavior stable while making daemon internals easier to reason about and safer to change in follow-up PRs.
What Changed
src/commands/tdd-daemon-process.jswith:readDaemonPidFile(...)findDaemonPidByPort(...)resolveDaemonPid(...)waitForProcessExit(...)src/commands/tdd-daemon.jsto import/re-export these helpers.Verification
node --test tests/commands/tdd-daemon.test.jsnpm run lintNotes
This is PR 2 in the tech-debt train and is intentionally behavior-preserving.