fix: use unique procedure names in tests to avoid overwriting production objects

Author: vkuttyp

Directory.Build.props

@@ -7,6 +7,6 @@
     <Authors>vkuttyp</Authors>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <RepositoryUrl>https://github.com/vkuttyp/CosmoSQLClient-Dotnet</RepositoryUrl>
-    <Version>1.9.7</Version>
+    <Version>1.9.8</Version>
   </PropertyGroup>
 </Project>

tests/CosmoSQLClient.MsSql.Tests/InvoiceHeaderProcedureTests.cs

@@ -1,3 +1,4 @@
+using System.Data;
 using CosmoSQLClient.Core;
 using CosmoSQLClient.MsSql;
 using Xunit;
@@ -10,25 +11,27 @@ public class InvoiceHeaderProcedureTests
     private static bool ShouldSkip => string.IsNullOrEmpty(EnvConn);
     private static string ConnectionString => EnvConn ?? "";
 
+    private const string TestProcName = "CosmoTest_InvoiceHeader";
+
     private async Task EnsureProcedureExists(MsSqlConnection conn)
     {
-        // Create a dummy InvoiceHeader procedure if it doesn't exist so the test can run in CI
-        await conn.ExecuteAsync(@"
-            IF OBJECT_ID('InvoiceHeader', 'P') IS NOT NULL DROP PROCEDURE InvoiceHeader;
+        // Create a dummy procedure if it doesn't exist so the test can run in CI
+        await conn.ExecuteAsync($@"
+            IF OBJECT_ID('{TestProcName}', 'P') IS NOT NULL DROP PROCEDURE {TestProcName};
         ");
-        
-        await conn.ExecuteAsync(@"
-            CREATE PROCEDURE InvoiceHeader
+
+        await conn.ExecuteAsync($@"
+            CREATE PROCEDURE {TestProcName}
                 @TransactionID NVARCHAR(50),
                 @FinancialYear INT,
                 @AdminUser INT,
                 @Language NVARCHAR(50)
             AS
             BEGIN
-                SELECT 
-                    @TransactionID as TransactionID, 
-                    @FinancialYear as FinancialYear, 
-                    @AdminUser as AdminUser, 
+                SELECT
+                    @TransactionID as TransactionID,
+                    @FinancialYear as FinancialYear,
+                    @AdminUser as AdminUser,
                     @Language as Language,
                     'Test' as DummyData;
             END
@@ -52,11 +55,14 @@ public async Task ExecuteInvoiceHeaderProcedure_ShouldSucceed()
             SqlParameter.Named("Language", SqlValue.From("English"))
         };
 
-        var result = await conn.ExecuteProcAsync("InvoiceHeader", parameters);
+        var result = await conn.ExecuteProcAsync(TestProcName, parameters);
 
         Assert.NotNull(result);
         Assert.Single(result.Rows);
         Assert.Equal("1-C-96/25", result.Rows[0]["TransactionID"].AsString());
+
+        // Cleanup
+        await conn.ExecuteAsync($"DROP PROCEDURE {TestProcName}");
     }
 
     [Fact]
@@ -68,7 +74,7 @@ public async Task ExecuteInvoiceHeaderAsRawSql_ShouldSucceed()
         await conn.OpenAsync();
         await EnsureProcedureExists(conn);
 
-        const string sql = "exec InvoiceHeader @TransactionID=@tid, @FinancialYear=@fy, @AdminUser=@au, @Language=@lang";
+        string sql = $"exec {TestProcName} @TransactionID=@tid, @FinancialYear=@fy, @AdminUser=@au, @Language=@lang";
 
         var parameters = new[]
         {
@@ -82,6 +88,10 @@ public async Task ExecuteInvoiceHeaderAsRawSql_ShouldSucceed()
 
         Assert.NotNull(rows);
         Assert.Single(rows);
+        Assert.Equal("1-C-96/25", rows[0]["TransactionID"].AsString());
+
+        // Cleanup
+        await conn.ExecuteAsync($"DROP PROCEDURE {TestProcName}");
     }
 
     [Fact]
@@ -93,21 +103,23 @@ public async Task DataTableLoad_WithMsSqlDataReader_ShouldHaveData()
         await conn.OpenAsync();
         await EnsureProcedureExists(conn);
 
-        using var cmd = conn.CreateCommand();
-        cmd.CommandText = "InvoiceHeader";
-        cmd.CommandType = System.Data.CommandType.StoredProcedure;
-        cmd.Parameters.Add(new MsSqlParameter("@TransactionID", "1-C-96/25"));
-        cmd.Parameters.Add(new MsSqlParameter("@FinancialYear", 2025));
-        cmd.Parameters.Add(new MsSqlParameter("@AdminUser", 1));
-        cmd.Parameters.Add(new MsSqlParameter("@Language", "English"));
+        using var cmd = new MsSqlCommand($"exec {TestProcName} @tid, @fy, @au, @lang", conn);
+        cmd.Parameters.AddWithValue("tid", "1-C-96/25");
+        cmd.Parameters.AddWithValue("fy", 2025);
+        cmd.Parameters.AddWithValue("au", 1);
+        cmd.Parameters.AddWithValue("lang", "English");
 
-        var table = new System.Data.DataTable("Header");
+        var table = new DataTable("Header");
         using var reader = await cmd.ExecuteReaderAsync();
 
         table.Load(reader);
 
         Assert.True(table.Columns.Count > 0, "DataTable should have columns");
         Assert.True(table.Rows.Count > 0, "DataTable should have rows");
         Assert.Equal("1-C-96/25", table.Rows[0]["TransactionID"]);
+        Assert.Equal("Test", table.Rows[0]["DummyData"]);
+
+        // Cleanup
+        await conn.ExecuteAsync($"DROP PROCEDURE {TestProcName}");
     }
 }