Skip to content

Commit 68cbd47

Browse files
vkuttypCopilot
andcommitted
fix: FillDataTableAsync must not use ConfigureAwait(false)
DataTable/DataGridView mutations must happen on the UI thread. ConfigureAwait(false) was scheduling FlushBatch on a thread-pool thread, so the DataGridView never received the bound changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 810b670 commit 68cbd47

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/SqlDotnetty.Core/ISqlDatabase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ public static async Task FillDataTableAsync(
191191
{
192192
var batch = new List<SqlRow>(batchSize);
193193

194-
await foreach (var row in rows.WithCancellation(ct).ConfigureAwait(false))
194+
await foreach (var row in rows.WithCancellation(ct))
195195
{
196196
// Ensure columns exist from the very first row
197197
if (table.Columns.Count == 0)

0 commit comments

Comments
 (0)