Skip to content

Commit 2b6dfad

Browse files
vkuttypCopilot
andcommitted
fix: use docker exec for sqlcmd instead of installing on runner
mssql-tools18 apt package is not available on ubuntu-24.04 runners. Use 'docker exec' to run sqlcmd inside the already-running MSSQL service container which has sqlcmd at /opt/mssql-tools18/bin/sqlcmd. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 54fe8b1 commit 2b6dfad

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -109,20 +109,13 @@ jobs:
109109
restore-keys: |
110110
${{ runner.os }}-spm-mssql-
111111
112-
- name: Install mssql-tools18
113-
run: |
114-
curl -fsSL https://packages.microsoft.com/keys/microsoft.asc \
115-
| sudo gpg --dearmor -o /usr/share/keyrings/microsoft-prod.gpg
116-
curl -fsSL https://packages.microsoft.com/config/ubuntu/24.04/prod.list \
117-
| sudo tee /etc/apt/sources.list.d/msprod.list
118-
sudo apt-get update -q
119-
ACCEPT_EULA=Y sudo apt-get install -y -q mssql-tools18 unixodbc-dev
120-
echo "/opt/mssql-tools18/bin" >> $GITHUB_PATH
121-
122112
- name: Create test database
123113
run: |
114+
container_id=$(docker ps --filter "ancestor=mcr.microsoft.com/mssql/server:2022-latest" \
115+
--format "{{.ID}}" | head -1)
124116
for i in $(seq 1 30); do
125-
/opt/mssql-tools18/bin/sqlcmd -S 127.0.0.1 -U sa -P 'aBCD111!' -C \
117+
docker exec "$container_id" /opt/mssql-tools18/bin/sqlcmd \
118+
-S localhost -U sa -P 'aBCD111!' -C \
126119
-Q "IF DB_ID('MSSQLNioTestDb') IS NULL CREATE DATABASE MSSQLNioTestDb" \
127120
2>/dev/null && echo "SQL Server ready." && break
128121
echo "Waiting for SQL Server... ($i/30)"; sleep 5

0 commit comments

Comments
 (0)