Skip to content

Commit 4004846

Browse files
vkuttypCopilot
andcommitted
fix: use mcr.microsoft.com/mssql-tools Docker image for sqlcmd
Avoids apt-get install sqlcmd which fails on ubuntu-24.04. Docker is pre-installed on GitHub Actions runners; the mssql-tools image provides sqlcmd at /opt/mssql-tools/bin/sqlcmd. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 83f9e47 commit 4004846

1 file changed

Lines changed: 13 additions & 17 deletions

File tree

.github/workflows/ci.yml

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,6 @@ jobs:
8787
- name: Install SQLite
8888
run: sudo apt-get install -y libsqlite3-dev
8989

90-
- name: Install sqlcmd
91-
run: |
92-
curl -fsSL https://packages.microsoft.com/keys/microsoft.asc \
93-
| sudo tee /etc/apt/trusted.gpg.d/microsoft.asc > /dev/null
94-
echo "deb [arch=amd64] https://packages.microsoft.com/ubuntu/24.04/prod noble main" \
95-
| sudo tee /etc/apt/sources.list.d/mssql-release.list
96-
sudo apt-get update -q
97-
sudo ACCEPT_EULA=Y apt-get install -y sqlcmd
98-
9990
- name: Cache SPM
10091
uses: actions/cache@v4
10192
with:
@@ -106,17 +97,22 @@ jobs:
10697
10798
- name: Create test database
10899
run: |
109-
sqlcmd -S "${{ secrets.DB_HOST }},1433" -U sa \
110-
-P "${{ secrets.MSSQL_TEST_PASS }}" \
111-
--trust-server-certificate \
112-
-Q "IF DB_ID('MSSQLNioTestDb') IS NULL CREATE DATABASE MSSQLNioTestDb"
100+
docker run --rm \
101+
mcr.microsoft.com/mssql-tools \
102+
/opt/mssql-tools/bin/sqlcmd \
103+
-S "${{ secrets.DB_HOST }},1433" -U sa \
104+
-P "${{ secrets.MSSQL_TEST_PASS }}" -C \
105+
-Q "IF DB_ID('MSSQLNioTestDb') IS NULL CREATE DATABASE MSSQLNioTestDb"
113106
114107
- name: Seed SQL Server database
115108
run: |
116-
sqlcmd -S "${{ secrets.DB_HOST }},1433" -U sa \
117-
-P "${{ secrets.MSSQL_TEST_PASS }}" \
118-
--trust-server-certificate \
119-
-i Tests/Resources/mssql_seed.sql
109+
docker run --rm \
110+
-v ${{ github.workspace }}/Tests/Resources:/seed \
111+
mcr.microsoft.com/mssql-tools \
112+
/opt/mssql-tools/bin/sqlcmd \
113+
-S "${{ secrets.DB_HOST }},1433" -U sa \
114+
-P "${{ secrets.MSSQL_TEST_PASS }}" -C \
115+
-i /seed/mssql_seed.sql
120116
121117
- name: Run MSSQL tests
122118
env:

0 commit comments

Comments
 (0)