Final robust byte-level encoding for RPC strings to eliminate memory leaks and alignment issues

vkuttyp · vkuttyp · commit 57e820664288 · 2026-03-06T01:55:07.000+03:00
diff --git a/Sources/CosmoMSSQL/TDS/TDSRPCRequest.swift b/Sources/CosmoMSSQL/TDS/TDSRPCRequest.swift
@@ -192,7 +192,8 @@ struct TDSRPCRequest {
         buf.writeInteger(UInt64(byteLen), endianness: .little)
         buf.writeInteger(UInt32(byteLen), endianness: .little)
         for unit in utf16 {
-            buf.writeInteger(unit, endianness: .little)
+            buf.writeInteger(UInt8(unit & 0xFF))
+            buf.writeInteger(UInt8((unit >> 8) & 0xFF))
         }
         buf.writeInteger(UInt32(0), endianness: .little)
     }
@@ -215,7 +216,8 @@ struct TDSRPCRequest {
         let utf16 = Array(s.utf16)
         buf.writeInteger(UInt8(utf16.count))
         for unit in utf16 {
-            buf.writeInteger(unit, endianness: .little)
+            buf.writeInteger(UInt8(unit & 0xFF))
+            buf.writeInteger(UInt8((unit >> 8) & 0xFF))
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,8 @@ struct TDSRPCRequest {`
`192`	`192`	`buf.writeInteger(UInt64(byteLen), endianness: .little)`
`193`	`193`	`buf.writeInteger(UInt32(byteLen), endianness: .little)`
`194`	`194`	`for unit in utf16 {`
`195`		`- buf.writeInteger(unit, endianness: .little)`
	`195`	`+ buf.writeInteger(UInt8(unit & 0xFF))`
	`196`	`+ buf.writeInteger(UInt8((unit >> 8) & 0xFF))`
`196`	`197`	`}`
`197`	`198`	`buf.writeInteger(UInt32(0), endianness: .little)`
`198`	`199`	`}`
`@@ -215,7 +216,8 @@ struct TDSRPCRequest {`
`215`	`216`	`let utf16 = Array(s.utf16)`
`216`	`217`	`buf.writeInteger(UInt8(utf16.count))`
`217`	`218`	`for unit in utf16 {`
`218`		`- buf.writeInteger(unit, endianness: .little)`
	`219`	`+ buf.writeInteger(UInt8(unit & 0xFF))`
	`220`	`+ buf.writeInteger(UInt8((unit >> 8) & 0xFF))`
`219`	`221`	`}`
`220`	`222`	`}`
`221`	`223`