Skip to content

Commit 462e282

Browse files
authored
Merge pull request #17 from alex-jw-brooks/v13_v16_compat
2 parents 1f9319d + 95cfd4f commit 462e282

1 file changed

Lines changed: 17 additions & 3 deletions

File tree

vllm_bart_plugin/bart.py

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,27 @@
3030
from transformers import BartConfig
3131
from transformers.utils import logging
3232

33-
from vllm.model_executor.layers.attention import Attention
34-
from vllm.v1.attention.backend import AttentionType
3533
from vllm.config import CacheConfig, VllmConfig
3634
from vllm.config.lora import LoRAConfig
3735
from vllm.config.multimodal import BaseDummyOptions
3836
from vllm.distributed import get_tensor_model_parallel_world_size
3937
from vllm.model_executor.layers.activation import get_act_fn
4038

39+
IS_LEGACY=False
4140
try:
41+
from vllm.v1.attention.backend import AttentionType
42+
from vllm.model_executor.layers.attention import Attention
4243
from vllm.model_executor.layers.attention.cross_attention import CrossAttention
4344
from vllm.model_executor.layers.attention.mm_encoder_attention import MMEncoderAttention
45+
from vllm.multimodal.processing.dummy_inputs import BaseDummyInputsBuilder
4446
except ImportError:
4547
# These were moved after vLLM 0.13; try the legacy path
48+
from vllm.attention.backends.abstract import AttentionType
49+
from vllm.attention.layer import Attention
4650
from vllm.attention.layers.cross_attention import CrossAttention
4751
from vllm.attention.layers.mm_encoder_attention import MMEncoderAttention
52+
from vllm.multimodal.profiling import BaseDummyInputsBuilder
53+
IS_LEGACY=True
4854

4955
from vllm.model_executor.layers.linear import (
5056
ColumnParallelLinear,
@@ -87,7 +93,6 @@
8793
EncDecMultiModalProcessor,
8894
PromptUpdate,
8995
)
90-
from vllm.multimodal.processing.dummy_inputs import BaseDummyInputsBuilder
9196
from vllm.sequence import IntermediateTensors
9297
from vllm.utils.collection_utils import is_list_of
9398

@@ -1011,6 +1016,15 @@ def _get_subparsers(self) -> Mapping[str, ModalityDataParser]:
10111016
class BartMultiModalProcessor(EncDecMultiModalProcessor[BartProcessingInfo]):
10121017
"""Multimodal processor for BART encoder-decoder models."""
10131018

1019+
def __init__(self, *args, **kwargs):
1020+
# HACK: v13 needs to define _get_data_parser, but v16 throws in __init__
1021+
# if this class has _get_data_parser as an attribute, so for now,
1022+
# we conditionally ist based on which import path was taken, since
1023+
# those are also changes that were needed for v13.
1024+
if IS_LEGACY:
1025+
self._get_data_parser = self.build_data_parser
1026+
super().__init__(*args, **kwargs)
1027+
10141028
def create_encoder_prompt(
10151029
self,
10161030
prompt: str | list[int],

0 commit comments

Comments
 (0)