docs(developing): add a proper Logging guide (#881)#898
Conversation
The Debug Logging section in docs/guides/troubleshooting.md links to developer/developing.md#logging for the full logging guide, but the existing content was a single env-var list nested under 'Developing the Web UI' rather than a standalone guide. Promote it to a top-level '## Logging' section (keeping the #logging anchor the troubleshooting links rely on) and expand it into an actual guide: an overview of the two logging sinks (human-readable console output on stdout and structured-JSON file output), the full set of GUIDELLM__LOGGING__* environment variables with accurate defaults from LoggingSettings, and console/file usage examples. Closes vllm-project#881 Signed-off-by: Anai-Guo <antai12232931@anaiguo.com>
jaredoconnell
left a comment
There was a problem hiding this comment.
I think this is close to ready. I have one comment.
| ## Logging | ||
|
|
||
| Logging is useful for learning how GuideLLM works and finding problems. | ||
| GuideLLM uses [Loguru](https://github.com/Delgan/loguru) for logging, which is useful for learning how GuideLLM works and for diagnosing problems. Logging is configured entirely through environment variables (or the equivalent `GUIDELLM__LOGGING__*` settings), so no code changes are needed to change what is logged or where it goes. |
There was a problem hiding this comment.
This seems a little confusing the way you mention the settings.
| GuideLLM uses [Loguru](https://github.com/Delgan/loguru) for logging, which is useful for learning how GuideLLM works and for diagnosing problems. Logging is configured entirely through environment variables (or the equivalent `GUIDELLM__LOGGING__*` settings), so no code changes are needed to change what is logged or where it goes. | |
| GuideLLM uses [Loguru](https://github.com/Delgan/loguru) for logging, which is useful for learning how GuideLLM works and for diagnosing problems. For CLI usage, logging is configured through environment variables (or a .env file using the same GUIDELLM__LOGGING__* keys), so no code changes are needed to change what is logged or where it goes. |
SkiHatDuckie
left a comment
There was a problem hiding this comment.
Also seems mostly good to me. In addition to Jared's suggestion:
| GUIDELLM__LOGGING__LOG_FILE=guidellm.log GUIDELLM__LOGGING__LOG_FILE_LEVEL=DEBUG guidellm run ... | ||
| ``` | ||
|
|
||
| If logging isn't responding to the environment variables, run the `guidellm config` command to validate that the environment variables match and are being set correctly. |
There was a problem hiding this comment.
| If logging isn't responding to the environment variables, run the `guidellm config` command to validate that the environment variables match and are being set correctly. | |
| If logging isn't responding to the environment variables, run the `guidellm env` command to validate that the environment variables match and are being set correctly. |
config has been renamed to env as of v0.7.0. Might as well update that too.
…ame, consolidate, guidellm env) Signed-off-by: Tai An <antai12232931@outlook.com>
|
Thanks all for the review. Addressed the feedback:
Let me know if the consolidation went too far or if you'd like the defaults restated inline. |
|
Hi @Anai-Guo, the DCO check has failed. Please click on DCO in the Checks section for instructions on how to resolve this. |
| ## Logging | ||
|
|
||
| GuideLLM uses [Loguru](https://github.com/Delgan/loguru) for logging, which is useful for learning how GuideLLM works and for diagnosing problems. Logging is configured entirely through environment variables (or the equivalent `GUIDELLM__LOGGING__*` settings), so no code changes are needed to change what is logged or where it goes. | ||
| Logging is controlled entirely through the `GUIDELLM__LOGGING__*` environment variables (or the equivalent settings object), so no code changes are needed to change what is logged or where it goes. |
There was a problem hiding this comment.
The "settings object" is a singleton that's only influenced by its default values and the environment variables. It's not a parameter anywhere, so the parenthetical statement isn't meaningful.
Now, as this is a "Developer" guide, perhaps you're trying to point out details of the implementation... but this document is focused more on tools and external controls, not source details. I think we should just remove the parenthetical statement.
| Logging is controlled entirely through the `GUIDELLM__LOGGING__*` environment variables (or the equivalent settings object), so no code changes are needed to change what is logged or where it goes. | ||
|
|
||
| GuideLLM writes to two independent sinks: | ||
| Logging is set through two independent outputs: |
There was a problem hiding this comment.
Maybe, "GuideLLM can log to the console, to a file, or to both:"
ff21b62 to
f6170d5
Compare
|
Fixed the DCO check (the follow-up commit was missing a sign-off). Heads-up on the merge conflict: Happy to redo this however is easiest for you: I can re-open a fresh branch with just the Logging edits layered on top of the current |
Summary
docs/guides/troubleshooting.md(Debug Logging) links todeveloper/developing.md#loggingfor the full logging guide, but that anchor pointed at a bare list of environment variables nested under Developing the Web UI — not the standalone guide the link implies. Fixes #881.Changes
### Loggingto a top-level## Loggingsection, keeping the#logginganchor that the two troubleshooting links depend on.stdout, controlled byGUIDELLM__LOGGING__CONSOLE_LOG_LEVEL(defaultWARNING).GUIDELLM__LOGGING__LOG_FILE/GUIDELLM__LOGGING__LOG_FILE_LEVEL(default fileguidellm.log, default levelINFO).GUIDELLM__LOGGING__*variables with defaults taken fromLoggingSettingsinsrc/guidellm/settings.pyand the sink behavior insrc/guidellm/logger.py.Docs-only; no code changes.
🤖 Generated with Claude Code
git log
commit 66cf2fe
Author: Anai-Guo antai12232931@anaiguo.com
Date: Sun Jul 5 14:50:52 2026 -0700
commit f6170d5
Author: Tai An antai12232931@outlook.com
Date: Mon Jul 6 19:09:14 2026 +0000
Signed-off-by: Anai-Guo antai12232931@anaiguo.com
Signed-off-by: Tai An antai12232931@outlook.com