fix code review

Author: ghkdwlgns612

helm/templates/ray-cluster.yaml

@@ -26,7 +26,7 @@ spec:
           {{- include "chart.engineLabels" . | nindent 10 }}
       spec:
         terminationGracePeriodSeconds: 0
-        {{- if hasKey $modelSpec "serviceAccountName" }}
+        {{- if $modelSpec.serviceAccountName }}
         serviceAccountName: {{ $modelSpec.serviceAccountName }}
         {{- end }}
         {{- with .Values.servingEngineSpec.securityContext }}
@@ -283,7 +283,7 @@ spec:
             helm-release-name: {{ .Release.Name }}
             {{- include "chart.engineLabels" . | nindent 12 }}
         spec:
-          {{- if hasKey $modelSpec "serviceAccountName" }}
+          {{- if $modelSpec.serviceAccountName }}
           serviceAccountName: {{ $modelSpec.serviceAccountName }}
           {{- end }}
           {{- with .Values.servingEngineSpec.securityContext }}

helm/tests/ray-cluster_test.yaml

@@ -525,3 +525,37 @@ tests:
     - documentIndex: 0
       isNull:
         path: spec.workerGroupSpecs[0].template.spec.serviceAccountName
+
+  - it: should not set serviceAccountName when set to empty string
+    release:
+      name: vllm
+    set:
+      servingEngineSpec:
+        enableEngine: true
+        modelSpec:
+          - name: "test-model"
+            repository: "vllm/vllm-openai"
+            tag: "latest"
+            modelURL: "facebook/opt-125m"
+            replicaCount: 1
+            requestCPU: 1
+            requestMemory: "1Gi"
+            requestGPU: 1
+            serviceAccountName: ""
+            raySpec:
+              enabled: true
+              headNode:
+                requestCPU: 1
+                requestMemory: "1Gi"
+                requestGPU: 1
+    asserts:
+    - documentIndex: 0
+      equal:
+        path: kind
+        value: RayCluster
+    - documentIndex: 0
+      isNull:
+        path: spec.headGroupSpec.template.spec.serviceAccountName
+    - documentIndex: 0
+      isNull:
+        path: spec.workerGroupSpecs[0].template.spec.serviceAccountName