Skip to content

Commit 80e2f84

Browse files
[bugfix] deprecate disable log request (#885)
* bugfix: deprecate disable log request Signed-off-by: Rui Zhang <zrfishnoodles@gmail.com> * Update helm/README.md Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rui Zhang <51696593+ruizhang0101@users.noreply.github.com> --------- Signed-off-by: Rui Zhang <zrfishnoodles@gmail.com> Signed-off-by: Rui Zhang <51696593+ruizhang0101@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 036e791 commit 80e2f84

25 files changed

Lines changed: 22 additions & 36 deletions

.github/values-01-2pods-minimal-example.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ servingEngineSpec:
2626

2727
vllmConfig:
2828
maxModelLen: 1024
29-
extraArgs: ["--disable-log-requests", "--gpu-memory-utilization", "0.4"]
29+
extraArgs: ["--gpu-memory-utilization", "0.4"]
3030

3131
routerSpec:
3232
repository: "localhost:5000/git-act-router"

benchmarks/multi-round-qa/model.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ servingEngineSpec:
2020
enablePrefixCaching: false
2121
maxModelLen: 4096
2222
dtype: "bfloat16"
23-
extraArgs: ["--disable-log-requests", "--gpu-memory-utilization", "0.8"]
23+
extraArgs: ["--gpu-memory-utilization", "0.8"]
2424

2525
lmcacheConfig:
2626
enabled: true

deployment_on_cloud/gcp/production_stack_specification_basic.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ servingEngineSpec:
2020
enablePrefixCaching: false
2121
maxModelLen: 4096
2222
dtype: "bfloat16"
23-
extraArgs: ["--disable-log-requests", "--gpu-memory-utilization", "0.8"]
23+
extraArgs: ["--gpu-memory-utilization", "0.8"]
2424

2525
hf_token: <YOUR HF TOKEN>

docs/source/deployment/crd.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ Sample Configurations
164164
tensorParallelSize: 1
165165
gpuMemoryUtilization: "0.8"
166166
maxLoras: 4
167-
extraArgs: ["--disable-log-requests"]
168167
v1: true
169168
port: 8000
170169
# Environment variables

docs/source/deployment/helm.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ Example Snippet
7373
enablePrefixCaching: false
7474
maxModelLen: 16384
7575
dtype: "bfloat16"
76-
extraArgs: ["--disable-log-requests", "--gpu-memory-utilization", "0.8"]
76+
extraArgs: ["--gpu-memory-utilization", "0.8"]
7777
7878
hf_token: <YOUR HF TOKEN>
7979
@@ -182,7 +182,7 @@ So far, you have configured and deployed a vLLM serving engine with a single GPU
182182
maxModelLen: 4096
183183
tensorParallelSize: 2
184184
dtype: "bfloat16"
185-
extraArgs: ["--disable-log-requests", "--gpu-memory-utilization", "0.8"]
185+
extraArgs: ["--gpu-memory-utilization", "0.8"]
186186
hf_token: <YOUR HF TOKEN>
187187
shmSize: "20Gi"
188188

examples/disaggregated_prefill/start_decode.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ docker run --runtime nvidia --gpus all \
2424
$IMAGE \
2525
meta-llama/Llama-3.1-8B-Instruct \
2626
--port 8200 \
27-
--disable-log-requests \
2827
--enforce-eager \
2928
--kv-transfer-config \
3029
'{"kv_connector":"LMCacheConnectorV1","kv_role":"kv_consumer","kv_connector_extra_config": {"discard_partial_chunks": false, "lmcache_rpc_port": "consumer1"}}'

examples/disaggregated_prefill/start_prefill.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ docker run --runtime nvidia --gpus all \
2525
$IMAGE \
2626
meta-llama/Llama-3.1-8B-Instruct \
2727
--port 8100 \
28-
--disable-log-requests \
2928
--enforce-eager \
3029
--kv-transfer-config \
3130
'{"kv_connector":"LMCacheConnectorV1","kv_role":"kv_producer","kv_connector_extra_config": {"discard_partial_chunks": false, "lmcache_rpc_port": "producer1"}}'

helm/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ This table documents all available configuration values for the Production Stack
143143
| `servingEngineSpec.modelSpec[].vllmConfig.gpuMemoryUtilization` | number | `0.9` | The fraction of GPU memory to be used for the model executor (0-1) |
144144
| `servingEngineSpec.modelSpec[].vllmConfig.runner` | string | `""` | The runner type for the model, can be "auto" or "pooling" |
145145
| `servingEngineSpec.modelSpec[].vllmConfig.convert` | string | `""` | The conversion type for the model, can be "token_embed", "embed", "token_classify", "classify", or "score" |
146-
| `servingEngineSpec.modelSpec[].vllmConfig.extraArgs` | list | `["--disable-log-requests"]` | Extra command line arguments to pass to vLLM |
146+
| `servingEngineSpec.modelSpec[].vllmConfig.extraArgs` | list | `["--trust-remote-code"]` | Extra command line arguments to pass to vLLM |
147147

148148
#### LMCache Configuration
149149

helm/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ servingEngineSpec:
8686
# - gpuMemoryUtilization: (optional, float) The fraction of GPU memory to be used for the model executor, which can range from 0 to 1. e.g., 0.95
8787
# - runner: (optional, string) The runner type for the model, can be "auto" or "pooling". e.g., "pooling"
8888
# - convert: (optional, string) The conversion type for the model, can be "token_embed", "embed", "token_classify", "classify", or "score". e.g., "embed"
89-
# - extraArgs: (optional, list) Extra command line arguments to pass to vLLM, e.g., ["--disable-log-requests"]
89+
# - extraArgs: (optional, list) Extra command line arguments to pass to vLLM, e.g., ["--gpu-memory-utilization", "0.4"]
9090
#
9191
# - lmcacheConfig: (optional, map) The configuration of the LMCache for KV offloading, supported options are:
9292
# - enabled: (optional, bool) Enable LMCache, e.g., true
@@ -204,7 +204,7 @@ servingEngineSpec:
204204
# maxNumSeqs: 32
205205
# gpuMemoryUtilization: 0.95
206206
# maxLoras: 4
207-
# extraArgs: ["--disable-log-requests", "--trust-remote-code"]
207+
# extraArgs: ["--trust-remote-code"]
208208
#
209209
# lmcacheConfig:
210210
# enabled: true

operator/config/samples/production-stack_v1alpha1_vllmruntime.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ spec:
2929
tensorParallelSize: 1
3030
gpuMemoryUtilization: "0.8"
3131
maxLoras: 4
32-
extraArgs: ["--disable-log-requests"]
3332
v1: true
3433
port: 8000
3534
# Environment variables

0 commit comments

Comments
 (0)