fix(operator): fix cr status base on deployment replicas (#443)

Signed-off-by: googs1025 <googs1025@gmail.com>
Co-authored-by: Roy Huang <roy.y.huang@gmail.com>

Author: googs1025

operator/internal/controller/cacheserver_controller.go

@@ -235,12 +235,14 @@ func (r *CacheServerReconciler) updateStatus(ctx context.Context, cs *production
 		latestCS.Status.LastUpdated = metav1.Now()
 
 		// Update status based on deployment status
-		if dep.Status.AvailableReplicas > 0 {
+		if dep.Status.AvailableReplicas == *dep.Spec.Replicas && dep.Status.UnavailableReplicas == 0 {
 			latestCS.Status.Status = "Ready"
-		} else if dep.Status.UpdatedReplicas > 0 {
+		} else if dep.Status.UpdatedReplicas > 0 && dep.Status.AvailableReplicas != *dep.Spec.Replicas && dep.Status.UnavailableReplicas > 0 {
 			latestCS.Status.Status = "Updating"
-		} else {
+		} else if dep.Status.UnavailableReplicas > 0 {
 			latestCS.Status.Status = "NotReady"
+		} else {
+			latestCS.Status.Status = "Unknown"
 		}
 
 		return r.Status().Update(ctx, latestCS)

operator/internal/controller/vllmrouter_controller.go

@@ -336,12 +336,14 @@ func (r *VLLMRouterReconciler) updateStatus(ctx context.Context, router *serving
 		latestRouter.Status.LastUpdated = metav1.Now()
 
 		// Update VLLMRouter status based on deployment status
-		if dep.Status.AvailableReplicas > 0 {
+		if dep.Status.AvailableReplicas == *dep.Spec.Replicas && dep.Status.UnavailableReplicas == 0 {
 			latestRouter.Status.Status = "Ready"
-		} else if dep.Status.UpdatedReplicas > 0 {
+		} else if dep.Status.UpdatedReplicas > 0 && dep.Status.AvailableReplicas != *dep.Spec.Replicas && dep.Status.UnavailableReplicas > 0 {
 			latestRouter.Status.Status = "Updating"
-		} else {
+		} else if dep.Status.UnavailableReplicas > 0 {
 			latestRouter.Status.Status = "NotReady"
+		} else {
+			latestRouter.Status.Status = "Unknown"
 		}
 
 		return r.Status().Update(ctx, latestRouter)

operator/internal/controller/vllmruntime_controller.go

@@ -518,13 +518,15 @@ func (r *VLLMRuntimeReconciler) updateStatus(ctx context.Context, vr *production
 		latestVR.Status.LastUpdated = metav1.Now()
 
 		// Update model status based on deployment status
-		if dep.Status.AvailableReplicas > 0 {
+		if dep.Status.AvailableReplicas == *dep.Spec.Replicas && dep.Status.UnavailableReplicas == 0 {
 			latestVR.Status.ModelStatus = "Ready"
-		} else if dep.Status.UpdatedReplicas > 0 {
+		} else if dep.Status.UpdatedReplicas > 0 && dep.Status.AvailableReplicas != *dep.Spec.Replicas && dep.Status.UnavailableReplicas > 0 {
 			// If we have updated replicas but they're not yet available, mark as updating
 			latestVR.Status.ModelStatus = "Updating"
-		} else {
+		} else if dep.Status.UnavailableReplicas > 0 {
 			latestVR.Status.ModelStatus = "NotReady"
+		} else {
+			latestVR.Status.ModelStatus = "Unknown"
 		}
 
 		return r.Status().Update(ctx, latestVR)