Adding support to route a request to a specific engine instance#438
Merged
Conversation
55073b2 to
9de9244
Compare
0f693d4 to
9de9244
Compare
Contributor
|
Hi! Would it be possible to add some tests to this feature? |
ahinsutime
reviewed
May 22, 2025
| existing_engines = set() | ||
| engines_cards = [] | ||
| for endpoint in endpoints: | ||
| if endpoint.model_name in existing_engines: |
Contributor
There was a problem hiding this comment.
Will it be better to check endpoint.Id (engine_id) instead of model_name?
If there are multiple replicas for the same model, only one of them will be considered.
Contributor
Author
There was a problem hiding this comment.
Yes! replaced with endpoint.Id
Collaborator
|
@dumb0002 Thanks! This is great! can you resolve the conflict? |
ffe2417 to
bed1529
Compare
Contributor
Author
Done! |
Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com>
bed1529 to
979d106
Compare
YuhanLiu11
approved these changes
Jun 2, 2025
YuhanLiu11
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks for your contribution!
JustinDuy
pushed a commit
to JustinDuy/production-stack-1
that referenced
this pull request
Jun 13, 2025
…-project#438) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com>
davidgao7
pushed a commit
to davidgao7/production-stack
that referenced
this pull request
Jun 26, 2025
…-project#438) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com> Signed-off-by: David Gao <davidgao313@outlook.com>
Senne-Mennes
pushed a commit
to Senne-Mennes/production-stack
that referenced
this pull request
Oct 22, 2025
…-project#438) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com> Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
emanuelecassese
pushed a commit
to emanuelecassese/production-stack
that referenced
this pull request
Jan 30, 2026
…-project#438) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com>
BadLord1st
pushed a commit
to BadLord1st/vllm-production-stack
that referenced
this pull request
Feb 1, 2026
…-project#438) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to route a request to a specific engine instance., e.g., vLLM v1
sleepandwake_upfor a specific vLLM engine.To achieve that we added the following features:
a) Add a end route to return the list of available engines and their serving models:
/engines, Methods: POST - For example:b) Add a route to send a inference to a specific engine instance based on the ID returned in (a) above. The engine ID is provided using a query string:
First PR for FIX to issue #391
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.