Enable first level of support for vLLM V1 Sleep & Wake_up Mode #441
Conversation
c707642 to
2ff0811
Compare
dcea3c9 to
2a35448
Compare
|
FYI, I see this PR is failing one of the tests - I checked it but I don't understand the root-cause - not sure if it's related with changes proposed in this PR. I see the following error from the test logs: |
0b6a679 to
7dc6a95
Compare
| added_timestamp=int(time.time()), | ||
| Id=str(uuid.uuid5(uuid.NAMESPACE_DNS, engine_name)), | ||
| model_label=model_label, | ||
| sleep=self._get_engine_sleep_status(engine_ip), |
There was a problem hiding this comment.
High level question: Should we watch the engine stats continuously instead of only calling this _get_engine_sleep_status once when it's added?
There was a problem hiding this comment.
The function _watch_engines timeouts every 30 seconds. Hence, I am taking advantage of this mechanism to continuously call _get_engine_sleep_status at the watch timeout interval.
There was a problem hiding this comment.
Also, this is first PR to support sleep & wake_up mode. I will submit a second PR to complete the design outlined in this issue # 391
There was a problem hiding this comment.
Here is the second PR that I referred in the comment above: #498
Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com>
7dc6a95 to
ff50fc4
Compare
YuhanLiu11
left a comment
There was a problem hiding this comment.
LGTM! Also tried on static service discovery and it works well on my side.
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
…oject#441) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com>
…oject#441) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com> Signed-off-by: David Gao <davidgao313@outlook.com>
…oject#441) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com> Signed-off-by: senne.mennes@capgemini.com <senne.mennes@capgemini.com>
…oject#441) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com>
…oject#441) Signed-off-by: Braulio Dumba <Braulio.Dumba@ibm.com> Co-authored-by: Braulio Dumba <Braulio.Dumba@ibm.com>
This PR enables the Production Stack router to support serving request for vLLM engines with the flag
--enable-sleep-modeset. The router does not forward requests to a sleeping engine. To achieve this, the router service discovery and request processing features were extended to check if an engine instance issleepingorwake_upand ready to process requests.Second PR for FIX to issue #391
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.