[Feat]: Add extraVolumeMount for initContainer#464
Open
JasmondL wants to merge 2 commits into
Open
Conversation
Add feature for initContainer to map extraVolumeMounts Signed-off-by: Jasmond Loh <Jasmond.Loh@hotmail.com>
JasmondL
force-pushed
the
feat/initContainer-vol
branch
from
83d0c78 to
0506a74
Compare
Author
|
@YuhanLiu11 Could you review this PR? |
Signed-off-by: Jasmond Loh <Jasmond.Loh@hotmail.com>
JasmondL
force-pushed
the
feat/initContainer-vol
branch
from
9fce28d to
5ed925a
Compare
Collaborator
|
Hey @JasmondL Thanks for the PR! Could you elaborate why code changes related to pod annotations are also included in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extraVolumeMount to the initContainer to facilitate the download of models or metadata to specific volume mounts.
This PR also includes changes to allow a list of imagePullSecrets. The reason behind this is that the initContainer and the main container may come from different repositories.