[Bugfix][Router] Fix router auth for transcription proxy#914
Merged
ruizhang0101 merged 2 commits intoApr 23, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a centralized _build_backend_request_headers function to handle header sanitization and authentication for backend requests, supported by new unit tests. Feedback points out that the current implementation may result in duplicate headers if Authorization or X-Request-Id are already present in the source request, and suggests lowering the log level for authentication messages to DEBUG to reduce log noise.
yzhan1
force-pushed
the
codex/fix-router-transcription-auth
branch
4 times, most recently
from
48294e6 to
38bea49
Compare
yzhan1
changed the title
Collaborator
|
Hi, I think this PR is good to go after resolving the conflict. |
Signed-off-by: Yaoming Zhan <yzhan@Mac.attlocal.net>
yzhan1
force-pushed
the
codex/fix-router-transcription-auth
branch
from
14b27c9 to
6611164
Compare
Contributor
Author
|
@ruizhang0101 thanks! Fixed the conflict |
ikaadil
pushed a commit
to ikaadil/production-stack
that referenced
this pull request
May 2, 2026
Signed-off-by: Yaoming Zhan <yzhan@Mac.attlocal.net> Co-authored-by: Yaoming Zhan <yzhan@Mac.attlocal.net> Co-authored-by: Rui Zhang <51696593+ruizhang0101@users.noreply.github.com> Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Typesoaiohttpcan generate the correct boundary for the rebuilt form bodyX-Request-Idon forwarded requests and add regression tests for both the JSON and multipart proxy pathsTesting
uv run --group test python -m pytest -q src/tests/test_request_auth_headers.py src/tests/test_audio_speech_routing.pyuv run --group test python -m pytest -q src/testsCloses #910.