[Bugfix][Router] Preserve full backend model metadata in /v1/models#927
Merged
ruizhang0101 merged 4 commits intoMay 7, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the preservation of extra metadata fields in ModelInfo and ensures they are returned by the models endpoint. While the implementation includes new tests, feedback highlights that instantiating ModelCard with these extra fields may cause excessive warning logs due to existing model validators. Additionally, it is recommended to move the known_fields set to a class-level constant to improve performance.
yzhan1
force-pushed
the
codex/debug-892-fork-updated
branch
from
6d3e092 to
8d88a03
Compare
Signed-off-by: Yaoming Zhan <yzhan@Mac.attlocal.net>
yzhan1
force-pushed
the
codex/debug-892-fork-updated
branch
from
8d88a03 to
576f488
Compare
Signed-off-by: Yaoming Zhan <yzhan@Mac.attlocal.net>
Collaborator
|
@yzhan1 Hi, Could you rebase on the base branch for merging? |
Contributor
Author
|
@ruizhang0101 Done. |
Collaborator
|
Hi seems like you need to rebase it again. I am not able to merge it for you for some reason, maybe you have protection on your branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #892 by preserving extra fields returned by backend
/v1/modelsresponses instead of rebuilding a minimal router-only model card.The change stores unknown backend model fields in
ModelInfo.extra_fieldsand serializes them back out from the router's/v1/modelsendpoint. That keeps metadata such asmax_model_lenandpermissionavailable to clients.Validation
uv run --group test python -m pytest -q src/tests/test_main_router_models.pyuv run --group test python -m pytest -q src/testsvllm/vllm-openai-cpu:latest-arm64):/v1/modelsincludedmax_model_lenandpermissionfork/mainrouter output dropped those fieldsbase_missing=['max_model_len', 'permission'],fix_missing=[])