[Bugfix] to shared storage not working with dynamic PV provisioning#933
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for shared PVC storage by updating the HF_HOME environment variable across vLLM deployments and Ray clusters. However, several critical issues were identified in the Helm templates. The logic in shared-storage.yaml incorrectly restricts PersistentVolume creation and storageClassName assignment when a storage class is defined, which breaks static provisioning. Additionally, while HF_HOME was updated in ray-cluster.yaml, the corresponding volume mounts for the shared storage are missing in both the head and worker groups, which will lead to runtime failures.
|
@NiccoloTosato Hi, could you sign the commit? |
c03e535 to
2e8d772
Compare
Hi, signature added, checklist updated. |
|
Hi I think there are still some past commits haven't signed, they need to be all signed for the CI to pass. The CI task is called DCO |
…o storageClass; set PVC.volumeName then Signed-off-by: Niccolo Tosato <niccolo.tosato@yahoo.it>
Signed-off-by: Niccolo Tosato <niccolo.tosato@yahoo.it>
Signed-off-by: Niccolo Tosato <niccolo.tosato@yahoo.it>
Signed-off-by: Niccolo Tosato <niccolo.tosato@yahoo.it>
2e8d772 to
14cd90a
Compare
This will fix #932
Summary
If shared storage is enabled, change
HF_HOMEfrom/datato/data/shared-pvc-storageChecklist
-swhen doinggit commit[Bugfix],[Feat], and[CI].