Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.10
version: 0.1.11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The pull request title is missing a classification prefix (e.g., [Misc] or [CI/Build]) as required by the repository's contribution guidelines. Additionally, the PR description checklist has not been completed. Please update the PR title and ensure the checklist is filled out to facilitate the review process.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Chart.yaml file is missing the appVersion field. For charts of type application, it is a best practice to include this field to track the version of the underlying application being deployed. Furthermore, the comments on lines 15-16 explicitly mention that this version number should be incremented along with the app version, yet the field is absent from the file. Consider adding appVersion: 0.1.11 (or the appropriate application version) to maintain consistency and provide better information to users.


maintainers:
- name: apostac
Expand Down
Loading