Skip to content

[BugFux] Fix help text formatting for Sentry sample rates in argument parser t… #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaoajie738 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[BugFux] Fix help text formatting for Sentry sample rates in argument parser t… #946

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b0c97a
Fix help text formatting for Sentry sample rates in argument parser t…
May 8, 2026
98d2c22
Merge branch 'main' into fix/argparse-help-percent-escape
ruizhang0101 May 14, 2026
f9f29ec
Merge branch 'main' into fix/argparse-help-percent-escape
ruizhang0101 May 26, 2026
4b625df
Merge branch 'main' into fix/argparse-help-percent-escape
ruizhang0101 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vllm_router/parsers/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,14 +396,14 @@ def parse_args():
"--sentry-traces-sample-rate",
type=float,
default=0.1,
help="The sample rate for Sentry traces. Default is 0.1 (10%)",
help="The sample rate for Sentry traces. Default is 0.1 (10%%)",
Comment thread
xiaoajie738 marked this conversation as resolved.
)

parser.add_argument(
"--sentry-profile-session-sample-rate",
type=float,
default=1.0,
help="The sample rate for Sentry profiling sessions. Default is 1.0 (100%)",
help="The sample rate for Sentry profiling sessions. Default is 1.0 (100%%)",

@gemini-code-assist gemini-code-assist Bot May 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider using %(default)s instead of hardcoding the default value 1.0 in the help string. This ensures the help message automatically updates if the default value is changed in the code. Note that the %% escape is still necessary for the literal percentage sign.

Suggested change
help="The sample rate for Sentry profiling sessions. Default is 1.0 (100%%)",
help="The sample rate for Sentry profiling sessions. Default is %(default)s (100%%)",

)

# OpenTelemetry tracing arguments
Expand Down
Loading