[Feat] Add per-model custom labels and podLabels to modelSpec#949
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to define per-model custom labels and pod labels in the multi-model vLLM deployment template. The changes include updates to the Helm chart templates, values schema, and default values, along with a new test case to verify that these labels are rendered correctly and do not leak into the selector match labels. The reviewer suggests reordering the label blocks in the templates to ensure that model-specific labels take precedence over standard labels by placing them after the helper includes.
NasAmin
force-pushed
the
feat/modelspec-custom-labels
branch
2 times, most recently
from
4d53164 to
b4d7ac1
Compare
ruizhang0101
left a comment
ruizhang0101
left a comment
There was a problem hiding this comment.
Could you add this to readme as well? Otherwise LGTM.
NasAmin
force-pushed
the
feat/modelspec-custom-labels
branch
from
b4d7ac1 to
f0c1bce
Compare
Thanks, readme updated |
Signed-off-by: Nasir Amin <nasir.amin@outlook.com>
Signed-off-by: Nasir Amin <nasir.amin@outlook.com>
NasAmin
force-pushed
the
feat/modelspec-custom-labels
branch
from
61adf38 to
859670d
Compare
|
@NasAmin Could you fix the pre-commit when you have time? |
Regenerate helm/values.schema.json so the labels property is placed in alphabetical order, matching the schema generator output. The committed schema had labels hand-placed after annotations, causing the CI 'Check if values schema is up-to-date' step to fail with a diff. Signed-off-by: Nasir Amin <nasir.amin@outlook.com>
@ruizhang0101 Sorry for the late reply. I have pushed a change but not sure if is successful as CI is blocked. |
2 participants
Add support for custom
labelsandpodLabelson a per-model basis viamodelSpec, similar to the existingannotationsandpodAnnotationsfields.labelsare applied to the Deployment resource metadata, andpodLabelsare applied to the pod template metadata. Neither is added toselector.matchLabelssince selectors are immutable after creation.Use case: Enables teams to apply custom labels per model for GPU scheduling (e.g., nodeAffinity rules driven by labels) and observability via pod metadata collection.
Changes:
helm/values.yaml— AddedlabelsandpodLabelsfields to modelSpechelm/values.schema.json— Added schema definitions for both fieldshelm/templates/deployment-vllm-multi.yaml— Render per-model labels on deployment and pod template metadatahelm/tests/deployment-vllm-multi_test.yaml— Added test verifying labels, podLabels, and selector isolationFIX #934