[FEAT][Helm] Support setting env for router#954
Conversation
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
There was a problem hiding this comment.
Code Review
This pull request enables the configuration of environment variables for the router component by adding an env field to the routerSpec. Changes include updating the deployment template to inject these variables, defining the field in the JSON schema, and providing a default empty list in values.yaml. Feedback suggests improving the JSON schema by explicitly defining the expected structure of the environment variable objects (e.g., name, value, valueFrom) to provide better validation for users.
| "env": { | ||
| "description": "List of environment variables to set for the router", | ||
| "type": "array" | ||
| }, |
There was a problem hiding this comment.
There was a problem hiding this comment.
This would limit the types of environment variables, as it could be coming from secret ref or configmap ref and not strictly name/value. Add all the types seems overly burdensome to this project.
Signed-off-by: Trey Dockendorf <tdockendorf@osc.edu>
Allow setting custom environment variables for the router. Right now we run the router as a specific UID and have to map the username like so:
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.