[CI] Bump memory for k8s discovery e2e tests#963
Conversation
Router resources 2G->4G; engine requestMemory 30Gi->40Gi. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request increases the requested memory for serving engines from 30Gi to 40Gi and router memory limits/requests from 2G to 4G across multiple configuration files. The reviewer suggests using binary SI suffixes (e.g., '4Gi' instead of '4G') for the router resources to prevent potential Out-Of-Memory (OOM) issues in Kubernetes and to maintain consistency with other memory definitions in the files.
| memory: "4G" | ||
| limits: | ||
| cpu: "1" | ||
| memory: "2G" | ||
| memory: "4G" |
There was a problem hiding this comment.
In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.
memory: "4Gi"
limits:
cpu: "1"
memory: "4Gi"| memory: "4G" | ||
| limits: | ||
| cpu: "1" | ||
| memory: "2G" | ||
| memory: "4G" |
There was a problem hiding this comment.
In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.
memory: "4Gi"
limits:
cpu: "1"
memory: "4Gi"| memory: "4G" | ||
| limits: | ||
| cpu: "1" | ||
| memory: "2G" | ||
| memory: "4G" |
There was a problem hiding this comment.
In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.
memory: "4Gi"
limits:
cpu: "1"
memory: "4Gi"| memory: "4G" | ||
| limits: | ||
| cpu: "1" | ||
| memory: "2G" | ||
| memory: "4G" |
There was a problem hiding this comment.
In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.
memory: "4Gi"
limits:
cpu: "1"
memory: "4Gi"
Router resources 2G→4G; engine
requestMemory30Gi→40Gi across e2e values files.🤖 Generated with Claude Code