Skip to content

[CI] Bump memory for k8s discovery e2e tests#963

Closed
ruizhang0101 wants to merge 1 commit into
mainfrom
ci/bump-e2e-memory
Closed

[CI] Bump memory for k8s discovery e2e tests#963
ruizhang0101 wants to merge 1 commit into
mainfrom
ci/bump-e2e-memory

Conversation

@ruizhang0101

Copy link
Copy Markdown
Collaborator

Router resources 2G→4G; engine requestMemory 30Gi→40Gi across e2e values files.

🤖 Generated with Claude Code

Router resources 2G->4G; engine requestMemory 30Gi->40Gi.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the requested memory for serving engines from 30Gi to 40Gi and router memory limits/requests from 2G to 4G across multiple configuration files. The reviewer suggests using binary SI suffixes (e.g., '4Gi' instead of '4G') for the router resources to prevent potential Out-Of-Memory (OOM) issues in Kubernetes and to maintain consistency with other memory definitions in the files.

Comment on lines +51 to +54
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Comment on lines +46 to +49
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Comment on lines +51 to +54
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Comment on lines +48 to +51
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is recommended to use binary SI suffixes (such as Gi for Gibibytes) instead of decimal suffixes (such as G for Gigabytes) for memory requests and limits. Using decimal units can lead to a ~7.3% reduction in allocated memory compared to binary units, which might cause unexpected Out-Of-Memory (OOM) issues. Additionally, using Gi here maintains consistency with the requestMemory: "40Gi" defined in the same file.

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

@ruizhang0101 ruizhang0101 deleted the ci/bump-e2e-memory branch May 28, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant