Skip to content

[CI] Bump memory for k8s discovery e2e tests#964

Closed
ruizhang0101 wants to merge 1 commit into
vllm-project:mainfrom
ruizhang0101:ci/bump-e2e-memory
Closed

[CI] Bump memory for k8s discovery e2e tests#964
ruizhang0101 wants to merge 1 commit into
vllm-project:mainfrom
ruizhang0101:ci/bump-e2e-memory

Conversation

@ruizhang0101

@ruizhang0101 ruizhang0101 commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Router resources 2G→4G; engine requestMemory 30Gi→40Gi across e2e values files.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the memory allocations across several configuration files, raising the serving engine memory request from 30Gi to 40Gi and the router memory requests and limits from 2G to 4G. The feedback advises using binary SI units (e.g., '4Gi' instead of '4G') for the router configurations to prevent potential Out-Of-Memory (OOM) issues and maintain consistency with the serving engine's memory specifications.

Comment on lines +51 to +54
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is standard practice to specify memory requests and limits using binary SI units (e.g., Gi) rather than decimal SI units (e.g., G). Since operating systems and runtimes measure memory in powers of two, using 4G (decimal) instead of 4Gi (binary) allocates approximately 7.3% less memory than expected, which can lead to unexpected Out-Of-Memory (OOM) kills. It is recommended to use 4Gi to ensure consistency with the serving engine's memory specification (40Gi).

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Comment on lines +46 to +49
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is standard practice to specify memory requests and limits using binary SI units (e.g., Gi) rather than decimal SI units (e.g., G). Since operating systems and runtimes measure memory in powers of two, using 4G (decimal) instead of 4Gi (binary) allocates approximately 7.3% less memory than expected, which can lead to unexpected Out-Of-Memory (OOM) kills. It is recommended to use 4Gi to ensure consistency with the serving engine's memory specification (40Gi).

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Comment on lines +51 to +54
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is standard practice to specify memory requests and limits using binary SI units (e.g., Gi) rather than decimal SI units (e.g., G). Since operating systems and runtimes measure memory in powers of two, using 4G (decimal) instead of 4Gi (binary) allocates approximately 7.3% less memory than expected, which can lead to unexpected Out-Of-Memory (OOM) kills. It is recommended to use 4Gi to ensure consistency with the serving engine's memory specification (40Gi).

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Comment on lines +48 to +51
memory: "4G"
limits:
cpu: "1"
memory: "2G"
memory: "4G"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, it is standard practice to specify memory requests and limits using binary SI units (e.g., Gi) rather than decimal SI units (e.g., G). Since operating systems and runtimes measure memory in powers of two, using 4G (decimal) instead of 4Gi (binary) allocates approximately 7.3% less memory than expected, which can lead to unexpected Out-Of-Memory (OOM) kills. It is recommended to use 4Gi to ensure consistency with the serving engine's memory specification (40Gi).

      memory: "4Gi"
    limits:
      cpu: "1"
      memory: "4Gi"

Router resources 2G->4G; engine requestMemory 30Gi->40Gi.

Signed-off-by: Rui Zhang <zrfishnoodles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant