docs: update KEDA autoscaling guide to use integrated monitoring sub-chart#965
Merged
ruizhang0101 merged 3 commits intoJun 19, 2026
Conversation
…chart Since v0.1.11 (PR vllm-project#860), monitoring (kube-prometheus-stack, prometheus-adapter) is available as an optional sub-chart dependency. The separate observability install script is no longer needed. Changes: - Replace 'cd observability && bash install.sh' with values.yaml configuration - Update Prometheus service addresses to match sub-chart naming - Add note about using existing external Prometheus stacks - Update version requirement to v0.1.11+ - Update cleanup section to reflect new approach Signed-off-by: Ahmad Salah <a.salah@sprinteins.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the KEDA autoscaling tutorial to use the integrated monitoring stack (via kube-prometheus-stack and prometheus-adapter sub-charts) introduced in v0.1.11 of the Helm chart. The review feedback highlights a premature verification step in Step 1 before the stack is actually deployed, recommends replacing the placeholders with the concrete release name 'vllm' to make configurations copy-pasteable, and suggests disabling the redundant prometheus-adapter since KEDA queries Prometheus directly.
- Remove premature verification block from Step 1 (Prometheus is not deployed until helm install in Step 2) - Replace <release-name> placeholder with 'vllm' for copy-paste-able examples - Remove prometheus-adapter from examples (not required for KEDA, which queries Prometheus directly via its built-in scaler) - Add note explaining when prometheus-adapter is actually needed Signed-off-by: Ahmad Salah <a.salah@sprinteins.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since v0.1.11 (PR #860), monitoring (
kube-prometheus-stack,prometheus-adapter) is available as an optional sub-chart dependency. The KEDA autoscaling tutorial still references the oldobservability/install.shscript which is no longer the recommended approach.This PR updates the documentation to reflect the new integrated monitoring setup.
Changes
cd observability && bash install.shwithvalues.yamlconfiguration (enablekube-prometheus-stackandserviceMonitorin values)<release-name>-kube-prometheus-stack-prometheus)serviceMonitor.enabled: trueneeded)Related