Skip to content

feat(helm/raySpec): allow customizing the Ray head node readiness probe (#742) #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

feat(helm/raySpec): allow customizing the Ray head node readiness probe (#742) #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm/templates/ray-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,15 @@ spec:
- name: {{ include "chart.container-port-name" . }}
containerPort: {{ include "chart.container-port" . }}
readinessProbe:
{{- if $modelSpec.raySpec.headNode.readinessProbe }}

@gemini-code-assist gemini-code-assist Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent potential template rendering errors (such as nil pointer evaluating interface{}), it is safer to guard the nested field access by checking if headNode is defined before accessing readinessProbe.

              {{- if and $modelSpec.raySpec.headNode $modelSpec.raySpec.headNode.readinessProbe }}

{{- toYaml $modelSpec.raySpec.headNode.readinessProbe | nindent 14 }}
{{- else }}
httpGet:
path: /health
port: {{ include "chart.container-port" . }}
failureThreshold: 1
periodSeconds: 10
{{- end }}
livenessProbe:
exec:
command: ["/bin/bash", "-c", "echo TBD"]
Expand Down
12 changes: 12 additions & 0 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,18 @@ servingEngineSpec:
requestMemory: "1Gi"
# -- GPU request for the head node
requestGPU: 1
# Readiness probe for the Ray head node (raySpec.headNode.readinessProbe).
# If unset, defaults to an httpGet /health probe with failureThreshold 1
# and periodSeconds 10. Override it to relax the probe when the model
# takes a long time to come up on a multi-node setup, otherwise the head
# pod may be marked unready and never receive traffic. Accepts a standard
# Kubernetes probe spec, e.g.:
# readinessProbe:
# httpGet:
# path: /health
# port: 8000
# failureThreshold: 10
# periodSeconds: 30

# -- Container port
containerPort: 8000
Expand Down
Loading