Add peagle test#530
Conversation
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR introduces PEagle as a new speculator type with corresponding test coverage, adjusts FSDP mixed-precision policy application at the model level, constrains model artifact resolution to specific file patterns, and updates offline training error handling from raise to skip on missing data. ChangesTraining infrastructure and PEagle speculator support
Possibly related PRs
Suggested labels
Suggested reviewers
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/speculators/train/utils.py`:
- Line 154: The root call to fully_shard is missing the mixed-precision policy
so the top-level parameters inherit default dtypes; update the call to
fully_shard at the end of the sharding sequence to pass the mp_policy argument
(i.e., replace the bare fully_shard(model) with a call that passes the existing
mp_policy variable to fully_shard) so the root module uses the same
MixedPrecisionPolicy as the child modules.
In `@tests/e2e/utils.py`:
- Around line 256-259: The test command currently appends "--on-missing", "skip"
to train_cmd which allows missing hidden states to be silently ignored; change
this to fail fast by replacing the "skip" value (or removing the flag) so
missing hidden states cause a test failure — locate the train_cmd construction
in tests/e2e/utils.py and update the "--on-missing" argument value to an
explicit failure mode (e.g., "error" or "fail") or remove the flag entirely to
ensure the test fails on missing data.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8487a20f-9a39-4742-bac5-61642cce590a
📒 Files selected for processing (4)
src/speculators/train/utils.pytests/e2e/regression/test_training_only_acceptance.pytests/e2e/smoke/test_offline_training.pytests/e2e/utils.py
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Added Peagle smoke/regression training
Description
Added training only regression test for p-eagle and offline training smoke test.
Related Issue
Tests
I have filled in: