GDN Decode kernel optimization#2671
Merged
Merged
Conversation
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
ca42250 to
92374ea
Compare
14782f5 to
972fe31
Compare
coolkp
reviewed
May 20, 2026
coolkp
approved these changes
May 20, 2026
972fe31 to
6d19704
Compare
6d19704 to
c5f1574
Compare
yaochengji
reviewed
May 20, 2026
yaochengji
approved these changes
May 21, 2026
88403f1 to
0168ba1
Compare
Signed-off-by: Haowen Ning <hning@google.com>
Signed-off-by: Haowen Ning <hning@google.com>
0168ba1 to
4faedf5
Compare
jrplatin
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimize gdn decode kernel
+--------+---------+---------+--------------+------------+------------+--------------+
| Decode | GDN Old | GDN New | GDN % | Kernel Old | Kernel New | Kernel % |
| Tokens | (us) | (us) | Difference | (us) | (us) | Difference |
+--------+---------+---------+--------------+------------+------------+--------------+
| 64 | 88.9 | 61.3 | -31.05% | 53.6 | 36.7 | -31.53% |
| 128 | 130.8 | 93.7 | -28.36% | 93.6 | 66.6 | -28.85% |
| 256 | 218.8 | 164 | -25.05% | 173.4 | 126 | -27.34% |
| 512 | 377 | 283 | -24.93% | 332 | 239 | -28.01% |
+--------+---------+---------+--------------+------------+------------+--------------+
Tests
Tested E2E benchmark.
Qwen 3.5 397B, total token throughput
1K/8K c64: 2051 -> 2163 (+5.5%)
8K/1K c64: 10745 -> 11522 (+7.2%)
Tested lm_eval mmlu_pro no regression
Checklist
Before submitting this PR, please make sure: