nano_nemotron_vl: fix tensor device mismatch exception when video profiling#39029
Merged
robertgshaw2-redhat merged 3 commits intoApr 5, 2026
Conversation
…filing Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _create_final_video_embeddings method in vllm/model_executor/models/nano_nemotron_vl.py to ensure that newly created tensors are placed on the same device as the video embeddings, preventing potential device mismatch issues. I have no feedback to provide as there are no review comments.
robertgshaw2-redhat
approved these changes
Apr 5, 2026
robertgshaw2-redhat
added
the
ready
milesial
approved these changes
Apr 5, 2026
HenryTangDev
pushed a commit
to HenryTangMain/vllm
that referenced
this pull request
Apr 6, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
puririshi98
pushed a commit
to puririshi98/vllm
that referenced
this pull request
Apr 7, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com> Signed-off-by: Rishi Puri <riship@nvidia.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
jhu960213
pushed a commit
to jhu960213/vllm
that referenced
this pull request
May 20, 2026
…filing (vllm-project#39029) Signed-off-by: Netanel Haber <58652339+netanel-haber@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.