fix: honor feature switch overrides in sandbox flags#12220
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
⚡ Lighthouse — Web
Tested URL: https://pr-12220-www.vm6.ai/ · Full report |
Contributor
Author
Code Review: PR #12220 (Round 1) — LGTM 🎉All P0 and P1 issues have been resolved. SummaryReviewed the feature switch override propagation through direct Zero runs, queued Zero dispatch, and internal runs. The optional override field is threaded into the execution context and evaluated once in the runner preparation path, so the stored runner job feature flags reflect user Lab overrides. Tests cover the direct Zero service path and internal route dispatch path. Verdict: LGTM ✅No critical or high-priority issues remaining. This PR is ready for merge. Completed after 1 round(s) of automated review-fix loop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
featureFlagswith those overrides so sandboxVM0_FEATURE_FLAGSreflects switches users enabled.Validation
Passed:
pnpm exec prettier --check apps/web/src/lib/infra/run/types.ts apps/web/src/lib/infra/run/context/execution-preparer.ts apps/web/src/lib/infra/run/context/build-context.ts apps/web/src/lib/zero/build-zero-context.ts apps/web/src/lib/zero/zero-run-service.ts apps/web/src/lib/zero/zero-run-queue-service.ts apps/web/app/api/agent/runs/route.ts apps/web/src/lib/zero/__tests__/zero-run-service.test.ts apps/web/app/api/agent/runs/__tests__/route.test.tspnpm --filter web lintpnpm exec vitest run packages/core/src/__tests__/feature-switch.test.tsBlocked locally:
pnpm exec vitest run apps/web/src/lib/zero/__tests__/zero-run-service.test.ts apps/web/app/api/agent/runs/__tests__/route.test.tsfails during setup because the local test DB is missing existing columnzero_agents.prefer_personal_provider.pnpm --filter web check-typesfails on unrelated pre-existing route type errors outside this change.pnpm --filter web db:migratefails because the local migration table is inconsistent with existing tableredemption_codes.