chore: track rust crates in release please#12249
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
Code Review: PR #12249SummaryReviewed the release-please Rust crate tracking changes. The PR is config-only and adds missing Rust workspace members to release-please tracking. Key FindingsCritical Issues (P0)
High Priority (P1)
Testing ReviewCoverage
Convention Compliance
Testing Verdict: Not ApplicableBad Smell Analysis
Recommendations
VerdictLGTM Full review details: |
41a1808 to
56929f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/api-contractsto release-please config and manifestapi-contracts-rsas the Rust component name to avoid colliding with the TypeScript packagecrates/sandbox-mockto release-please config and skip changelog for internal/helper cratesVerification
jq empty release-please-config.json .release-please-manifest.jsoncargo metadataagainst release-please config and manifest