Skip to content

chore: track rust crates in release please#12249

Merged
seven332 merged 1 commit into
mainfrom
chore/release-please-rust-crates
May 9, 2026
Merged

chore: track rust crates in release please#12249
seven332 merged 1 commit into
mainfrom
chore/release-please-rust-crates

Conversation

@seven332
Copy link
Copy Markdown
Contributor

@seven332 seven332 commented May 8, 2026

Summary

  • add crates/api-contracts to release-please config and manifest
  • use api-contracts-rs as the Rust component name to avoid colliding with the TypeScript package
  • add crates/sandbox-mock to release-please config and skip changelog for internal/helper crates

Verification

  • jq empty release-please-config.json .release-please-manifest.json
  • compared Rust workspace members from cargo metadata against release-please config and manifest

@seven332 seven332 self-assigned this May 8, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in VM0 Kanban May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@seven332
Copy link
Copy Markdown
Contributor Author

seven332 commented May 8, 2026

Code Review: PR #12249

Summary

Reviewed the release-please Rust crate tracking changes. The PR is config-only and adds missing Rust workspace members to release-please tracking.

Key Findings

Critical Issues (P0)

  • None.

High Priority (P1)

  • None.

Testing Review

Coverage

  • chore: release-please config/manifest alignment -> no behavioral test required.
  • Verified JSON syntax and checked Rust workspace members from cargo metadata against both release-please config and manifest.

Convention Compliance

  • No test files changed. No testing convention violations.

Testing Verdict: Not Applicable

Bad Smell Analysis

  • Mock violations: 0
  • Test coverage issues: 0
  • Defensive programming: 0
  • Dynamic imports: 0
  • Type safety issues: 0
  • Hardcoded configuration issues: 0
  • Lint/type suppressions: 0
  • Timer/delay issues: 0

Recommendations

  • No blocking recommendations. The api-contracts-rs component avoids collision with the TypeScript api-contracts package, and skip-changelog is appropriate for the generated/helper Rust crates.

Verdict

LGTM


Full review details: codereviews/20260509/
Testing standards: docs/testing.md

@seven332 seven332 force-pushed the chore/release-please-rust-crates branch from 41a1808 to 56929f9 Compare May 9, 2026 01:27
@seven332 seven332 enabled auto-merge May 9, 2026 01:27
@seven332 seven332 added this pull request to the merge queue May 9, 2026
Merged via the queue into main with commit 5421117 May 9, 2026
70 of 71 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in VM0 Kanban May 9, 2026
@github-actions github-actions Bot deleted the chore/release-please-rust-crates branch May 9, 2026 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant