revert: remove bounded exec rollout

[seven332]

Summary

• revert the bounded exec protocol, guest, host, sandbox, and runner rollout
• revert host-initiated vsock control handshake changes that were built on the same path
• restore runner internals to legacy exec/log copy paths

Reverted commits

• 70aa4eb docs: document bounded exec preference (docs: document bounded exec preference #12599)
• ee551da refactor(runner): stream exec over bounded exec (refactor(runner): stream exec over bounded exec #12518)
• de17089 feat: add host-initiated vsock control handshake (feat: add host-initiated vsock control handshake #12543)
• a842925 perf(runner): stream guest log copies (perf(runner): stream guest log copies #12418)
• 41d5d12 refactor(runner): include bounded exec diagnostics (refactor(runner): include bounded exec diagnostics #12368)
• f0b84b4 refactor(runner): migrate internal execs to bounded exec (refactor(runner): migrate internal execs to bounded exec #12322)
• 71f6ad9 feat: add bounded exec output policies (feat: add bounded exec output policies #12292)
• 9a8063a perf(vsock-host): cap bounded exec stream forwarding (perf(vsock-host): cap bounded exec stream forwarding #12267)
• 1860100 fix(vsock-host): poison interrupted frame writes (fix(vsock-host): poison interrupted frame writes #12247)
• 71602f2 feat(sandbox): wire bounded exec through host and firecracker sandbox (feat(sandbox): wire bounded exec through host and firecracker sandbox #12203)
• f2b85dd feat(vsock-guest): implement bounded exec (feat(vsock-guest): implement bounded exec #12164)
• 2050fb2 feat(vsock): add bounded exec protocol messages (feat(vsock): add bounded exec protocol messages #12119)

Verification

• cargo check --manifest-path crates/Cargo.toml -p runner -p sandbox -p sandbox-fc -p sandbox-mock -p vsock-proto -p vsock-host -p vsock-guest
• cargo test --manifest-path crates/Cargo.toml -p vsock-proto -p vsock-host -p vsock-guest -p sandbox -p sandbox-mock -p runner --lib
• cargo test --manifest-path crates/Cargo.toml -p runner --bin runner
• pre-commit cargo-fmt/cargo-doc/cargo-clippy

[codecov]

Codecov Report

❌ Patch coverage is 88.36478% with 37 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
crates/sandbox-fc/src/control.rs	77.90%	19 Missing ⚠️
crates/runner/src/executor.rs	92.62%	9 Missing ⚠️
crates/sandbox-fc/src/snapshot.rs	0.00%	9 Missing ⚠️

📢 Thoughts on this report? Let us know!

[seven332]

Code Review: PR #12654

Summary

Reviewed the rollback commit. It removes the bounded exec protocol/guest/host/sandbox/runner rollout, the bounded-exec guest log copy path, and the host-initiated vsock control handshake. I did not find blocking or non-blocking issues.

Key Findings

Critical Issues (P0)

• None.

High Priority (P1)

• None.

Medium Priority (P2)

• None.

Testing Review

Coverage

• Revert/removal of bounded exec/control behavior: adequate. Removed tests correspond to removed behavior; surviving legacy exec/control behavior is covered by existing Rust tests.
• Verified locally:
  • cargo check --manifest-path crates/Cargo.toml -p runner -p sandbox -p sandbox-fc -p sandbox-mock -p vsock-proto -p vsock-host -p vsock-guest
  • cargo test --manifest-path crates/Cargo.toml -p vsock-proto -p vsock-host -p vsock-guest -p sandbox -p sandbox-mock -p runner --lib
  • cargo test --manifest-path crates/Cargo.toml -p runner --bin runner
  • pre-commit cargo-fmt / cargo-doc / cargo-clippy

Convention Compliance

• No new mocks, fake timers, filesystem mocks, direct DB operations, lint suppressions, or internal module mock violations found.

Testing Verdict: Adequate

Bad Smell Analysis

• Mock violations: 0
• Test coverage issues: 0
• Defensive programming issues: 0
• Dynamic imports: 0
• Type safety issues: 0
• Lint/type suppressions: 0
• Hardcoded URL/config issues: 0
• Artificial delays: 0

Recommendations

• None.

Verdict

LGTM

---

Full review details: codereviews/20260511/commit-list-12654.md
Testing standards: docs/testing.md