QS wheel factorization validation

Author: WrathfulSpatula

FindAFactor/_find_a_factor.cpp

@@ -390,12 +390,12 @@ struct Factorizer {
   {
     smoothNumberKeys.reserve(rowLimit);
     smoothNumberValues.reserve(rowLimit);
-    for (const size_t p : smoothPrimes) {
-      smoothWheelRadius *= p;
-    }
     while (smoothPrimes.size() && (smoothPrimes[0U] <= wfl)) {
       smoothPrimes.erase(smoothPrimes.begin());
     }
+    for (const size_t p : smoothPrimes) {
+      smoothWheelRadius *= p;
+    }
   }
 
   BigInteger getNextBatch() {
@@ -443,6 +443,10 @@ struct Factorizer {
 
   // Sieving function
   BigInteger sievePolynomials(std::vector<boost::dynamic_bitset<size_t>> *inc_seqs) {
+    if (smoothWheelRadius < 2U) {
+      throw std::invalid_argument("Wheel factorization level setting excludes all smooth primes!");
+    }
+
     for (BigInteger batchNum = getNextBatch(); isIncomplete; batchNum = getNextBatch()) {
       // NOTE: If you want to add gear factorization back in, realize that these bounds
       // do not yet properly align to exact wheel boundaries, for full repetitions.

pyproject.toml

@@ -8,7 +8,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "findafactor"
-version = "6.8.1"
+version = "6.8.2"
 requires-python = ">=3.8"
 description = "Find any nontrivial factor of a number"
 readme = {file = "README.txt", content-type = "text/markdown"}

setup.py

@@ -40,7 +40,7 @@ def build_extension(self, ext):
 
 setup(
     name='findafactor',
-    version='6.8.1',
+    version='6.8.2',
     author='Dan Strano',
     author_email='stranoj@gmail.com',
     description='Find any nontrivial factor of a number',