TMCRootManager: implemented RNTuple writer#28
Open
karabowi wants to merge 3 commits into
Open
Conversation
ihrivnac
reviewed
Jun 26, 2026
Comment on lines
+21
to
+22
| #include "TFile.h" | ||
| #include "TTree.h" |
Contributor
There was a problem hiding this comment.
These includes should be removed from .cxx
Comment on lines
+102
to
+103
| TFile *fFile {0}; // Root output file | ||
| TTree *fTree {0}; // Root output tree |
Comment on lines
+150
to
+153
| TString fileName = Form("T%s",projectName); | ||
| if (fStorageMode == kRNTuple) { | ||
| fileName = Form("R%s",projectName); | ||
| } |
Contributor
There was a problem hiding this comment.
The file name should not be modified here; this should be removed.
Then in E03 example, we should better duplicate run_g4.C in run_g4a,b,c,d.C to avoid overwrite the output from each example.
Author
|
I have applied the requested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the TMCRootManager store data in TTree or RNTuple format.