fix(scan): decode html entities in probe title (#354)

TBX3D · web-flow · commit c5fed20d868a · 2026-07-22T12:56:38.000-07:00
the probe title field is documented as an httpx-style page title, but
extractTitle returned the raw regex capture, so a title like
"Tom &amp;amp; Jerry" was reported verbatim instead of "Tom &amp; Jerry".
run it through html.UnescapeString before trimming so the reported
title matches the rendered page.
diff --git a/internal/scan/probe.go b/internal/scan/probe.go
@@ -15,6 +15,7 @@ package scan
 import (
 	"context"
 	"fmt"
+	"html"
 	"io"
 	"net/http"
 	"regexp"
@@ -133,13 +134,14 @@ func Probe(targetURL string, timeout time.Duration, logdir string) (*ProbeResult
 }
 
 // extractTitle returns the trimmed text of the first <title> in body, or "" when
-// there isn't one.
+// there isn't one. html entities are decoded so the title matches the rendered
+// page rather than carrying raw "&amp;"-style markup.
 func extractTitle(body []byte) string {
 	m := titleRe.FindSubmatch(body)
 	if len(m) < 2 {
 		return ""
 	}
-	return strings.TrimSpace(string(m[1]))
+	return strings.TrimSpace(html.UnescapeString(string(m[1])))
 }
 
 // ResultType identifies probe results for the result registry.
diff --git a/internal/scan/probe_test.go b/internal/scan/probe_test.go
@@ -108,6 +108,7 @@ func TestProbe_ExtractTitle(t *testing.T) {
 		{"trimmed", "<title>  spaced  </title>", "spaced"},
 		{"attrs", `<title lang="en">attr</title>`, "attr"},
 		{"multiline", "<title>line one\nline two</title>", "line one\nline two"},
+		{"entities", "<title>Tom &amp; Jerry &#8211; Home</title>", "Tom & Jerry – Home"},
 		{"none", "<html><body>no title</body></html>", ""},
 	}
 	for _, tt := range tests {

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ func TestProbe_ExtractTitle(t *testing.T) {`
`108`	`108`	`{"trimmed", "<title> spaced </title>", "spaced"},`
`109`	`109`	{"attrs", `<title lang="en">attr</title>`, "attr"},
`110`	`110`	`{"multiline", "<title>line one\nline two</title>", "line one\nline two"},`
	`111`	`+ {"entities", "<title>Tom & Jerry – Home</title>", "Tom & Jerry – Home"},`
`111`	`112`	`{"none", "<html><body>no title</body></html>", ""},`
`112`	`113`	`}`
`113`	`114`	`for _, tt := range tests {`