feat(modules): add nsq and pulsar exposure modules#297
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage ? 54.72%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3762
Misses ? 2842
Partials ? 270 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
modules
pr summary4 files changed (+263 -0)
|
drop the leading comment restating id/name on nsq-stats-exposure and pulsar-metrics-exposure
vmfunc
left a comment
vmfunc
left a comment
There was a problem hiding this comment.
both rules lean on the right anchors. topics+start_time+version and'd is specific enough that no generic json trips the nsq rule, and pulsar_topics_count + pulsar_subscriptions_count + ^# TYPE pulsar_ won't collide with node_exporter. negative tests for 401/404/partial-body are the ones that matter and you've got them.
one thing on nsq: requiring "health":"OK" in the and-set means a degraded-but-exposed nsqd (health NOK) slips through, and the other three anchors already pin it to nsqd. not blocking, an exposure is an exposure even when it's unhealthy, so you might drop that matcher later. in as-is.
3 participants
No description provided.