fix(scan): decode html entities in probe title#354
Merged
Conversation
the probe title field is documented as an httpx-style page title, but extractTitle returned the raw regex capture, so a title like "Tom & Jerry" was reported verbatim instead of "Tom & Jerry". run it through html.UnescapeString before trimming so the reported title matches the rendered page.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage ? 54.72%
=======================================
Files ? 81
Lines ? 6874
Branches ? 0
=======================================
Hits ? 3762
Misses ? 2842
Partials ? 270 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-actions
Bot
added
scan
pr summary2 files changed (+5 -2)
|
vmfunc
approved these changes
Jul 22, 2026
vmfunc
left a comment
vmfunc
left a comment
Owner
There was a problem hiding this comment.
unescape-before-trim is the right order here, an edge entity that decodes to whitespace still gets trimmed. title's display-only so nothing downstream regresses. in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the probe's extracted page title carried raw html entities (Tom & Jerry) instead of the decoded text a browser would render, since there was no entity-decoding step after pulling the <title> text out. decode entities so the title matches the rendered page.