Skip to content

fix: encode non-addressable values with pointer receiver methods #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yanhu007 wants to merge 1 commit into
base: v5
Choose a base branch
from
+12 −4
Open

fix: encode non-addressable values with pointer receiver methods #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions encode_value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ func ptrEncoderFunc(typ reflect.Type) encoderFunc {

func encodeCustomValuePtr(e *Encoder, v reflect.Value) error {
if !v.CanAddr() {
return fmt.Errorf("msgpack: Encode(non-addressable %T)", v.Interface())
vp := reflect.New(v.Type())
vp.Elem().Set(v)
v = vp.Elem()
}
encoder := v.Addr().Interface().(CustomEncoder)
return encoder.EncodeMsgpack(e)
Expand All @@ -151,7 +153,9 @@ func encodeCustomValue(e *Encoder, v reflect.Value) error {

func marshalValuePtr(e *Encoder, v reflect.Value) error {
if !v.CanAddr() {
return fmt.Errorf("msgpack: Encode(non-addressable %T)", v.Interface())
vp := reflect.New(v.Type())
vp.Elem().Set(v)
v = vp.Elem()
}
return marshalValue(e, v.Addr())
}
Expand Down Expand Up @@ -211,7 +215,9 @@ func nilableType(t reflect.Type) bool {

func marshalBinaryValueAddr(e *Encoder, v reflect.Value) error {
if !v.CanAddr() {
return fmt.Errorf("msgpack: Encode(non-addressable %T)", v.Interface())
vp := reflect.New(v.Type())
vp.Elem().Set(v)
v = vp.Elem()
}
return marshalBinaryValue(e, v.Addr())
}
Expand All @@ -234,7 +240,9 @@ func marshalBinaryValue(e *Encoder, v reflect.Value) error {

func marshalTextValueAddr(e *Encoder, v reflect.Value) error {
if !v.CanAddr() {
return fmt.Errorf("msgpack: Encode(non-addressable %T)", v.Interface())
vp := reflect.New(v.Type())
vp.Elem().Set(v)
v = vp.Elem()
}
return marshalTextValue(e, v.Addr())
}
Expand Down