fix: Use localStorage for memqueue tests instead of Redis for #162#163
Merged
Merged
Conversation
Contributor
Author
|
Let me know if you want me to fix the commitlint complaint ( |
Owner
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structured similarly to how #106 moved storage to storage.go, but I made a few changes:
NewLocalStorage()function to allow taskq users to doopt.Storage = taskq.NewLocalStorage(), as I agree with your comment in fixed panics on msg.Name != "" & redis is disabled #106 that introducing a new default will be unexpected by most and I'd also rather see an error when storage is not configuredNewLocalStorage()andnewRedisStorage()returnStorageinterfaces instead of their internal types