fix(teams): omit group_id from Create/Update payload when empty

Closes #56

Author: vmvarela

github/provider.go

@@ -213,6 +213,9 @@ func Provider() *schema.Provider {
 			"github_user_invitation_accepter":                                       resourceGithubUserInvitationAccepter(),
 			"github_user_ssh_key":                                                   resourceGithubUserSshKey(),
 			"github_enterprise_organization":                                        resourceGithubEnterpriseOrganization(),
+			"github_enterprise_team":                                                resourceGithubEnterpriseTeam(),
+			"github_enterprise_team_membership":                                     resourceGithubEnterpriseTeamMembership(),
+			"github_enterprise_team_organizations":                                  resourceGithubEnterpriseTeamOrganizations(),
 			"github_enterprise_actions_runner_group":                                resourceGithubActionsEnterpriseRunnerGroup(),
 			"github_enterprise_actions_workflow_permissions":                        resourceGithubEnterpriseActionsWorkflowPermissions(),
 			"github_actions_organization_workflow_permissions":                      resourceGithubActionsOrganizationWorkflowPermissions(),
@@ -294,10 +297,10 @@ func Provider() *schema.Provider {
 			"github_user_external_identity":                                         dataSourceGithubUserExternalIdentity(),
 			"github_users":                                                          dataSourceGithubUsers(),
 			"github_enterprise":                                                     dataSourceGithubEnterprise(),
-			"github_enterprise_scim_groups":                                         dataSourceGithubEnterpriseSCIMGroups(),
-			"github_enterprise_scim_group":                                          dataSourceGithubEnterpriseSCIMGroup(),
-			"github_enterprise_scim_users":                                          dataSourceGithubEnterpriseSCIMUsers(),
-			"github_enterprise_scim_user":                                           dataSourceGithubEnterpriseSCIMUser(),
+			"github_enterprise_team":                                                dataSourceGithubEnterpriseTeam(),
+			"github_enterprise_teams":                                               dataSourceGithubEnterpriseTeams(),
+			"github_enterprise_team_membership":                                     dataSourceGithubEnterpriseTeamMembership(),
+			"github_enterprise_team_organizations":                                  dataSourceGithubEnterpriseTeamOrganizations(),
 			"github_repository_environment_deployment_policies":                     dataSourceGithubRepositoryEnvironmentDeploymentPolicies(),
 		},
 	}

github/resource_github_enterprise_team.go

@@ -88,11 +88,13 @@ func resourceGithubEnterpriseTeamCreate(ctx context.Context, d *schema.ResourceD
 	req := github.EnterpriseTeamCreateOrUpdateRequest{
 		Name:                      name,
 		OrganizationSelectionType: github.Ptr(orgSelection),
-		GroupID:                   github.Ptr(groupID), // Empty string is valid for no group
 	}
 	if description != "" {
 		req.Description = github.Ptr(description)
 	}
+	if groupID != "" {
+		req.GroupID = github.Ptr(groupID)
+	}
 
 	ctx = context.WithValue(ctx, ctxId, d.Id())
 	te, _, err := client.Enterprise.CreateTeam(ctx, enterpriseSlug, req)
@@ -210,11 +212,13 @@ func resourceGithubEnterpriseTeamUpdate(ctx context.Context, d *schema.ResourceD
 	req := github.EnterpriseTeamCreateOrUpdateRequest{
 		Name:                      name,
 		OrganizationSelectionType: github.Ptr(orgSelection),
-		GroupID:                   github.Ptr(groupID), // Empty string clears the group
 	}
 	if description != "" {
 		req.Description = github.Ptr(description)
 	}
+	if groupID != "" {
+		req.GroupID = github.Ptr(groupID)
+	}
 
 	ctx = context.WithValue(ctx, ctxId, d.Id())
 	te, _, err := client.Enterprise.UpdateTeam(ctx, enterpriseSlug, teamSlug, req)

website/github.erb

@@ -101,16 +101,16 @@
               <a href="/docs/providers/github/d/enterprise.html">github_enterprise</a>
             </li>
             <li>
-              <a href="/docs/providers/github/d/enterprise_scim_group.html">github_enterprise_scim_group</a>
+              <a href="/docs/providers/github/d/enterprise_team.html">github_enterprise_team</a>
             </li>
             <li>
-              <a href="/docs/providers/github/d/enterprise_scim_groups.html">github_enterprise_scim_groups</a>
+              <a href="/docs/providers/github/d/enterprise_team_membership.html">github_enterprise_team_membership</a>
             </li>
             <li>
-              <a href="/docs/providers/github/d/enterprise_scim_user.html">github_enterprise_scim_user</a>
+              <a href="/docs/providers/github/d/enterprise_team_organizations.html">github_enterprise_team_organizations</a>
             </li>
             <li>
-              <a href="/docs/providers/github/d/enterprise_scim_users.html">github_enterprise_scim_users</a>
+              <a href="/docs/providers/github/d/enterprise_teams.html">github_enterprise_teams</a>
             </li>
             <li>
               <a href="/docs/providers/github/d/external_groups.html">github_external_groups</a>
@@ -325,6 +325,15 @@
             <li>
               <a href="/docs/providers/github/r/enterprise_security_analysis_settings.html">github_enterprise_security_analysis_settings</a>
             </li>
+            <li>
+              <a href="/docs/providers/github/r/enterprise_team.html">github_enterprise_team</a>
+            </li>
+            <li>
+              <a href="/docs/providers/github/r/enterprise_team_membership.html">github_enterprise_team_membership</a>
+            </li>
+            <li>
+              <a href="/docs/providers/github/r/enterprise_team_organizations.html">github_enterprise_team_organizations</a>
+            </li>
             <li>
               <a href="/docs/providers/github/r/issue.html">github_issue</a>
             </li>