This repository was archived by the owner on Apr 15, 2026. It is now read-only.
fix(enterprise-teams): use read-only language in data source Descriptions#44
Merged
fix(enterprise-teams): use read-only language in data source Descriptions#44
Conversation
…ions Replace "Lists..." with "Retrieves information about..." in: - data_source_github_enterprise_teams.go - data_source_github_enterprise_team_organizations.go Data sources are read-only; their Description must not imply mutation. Consistent with provider conventions and reviewer feedback on upstream PR integrations#3008. Closes #24
vmvarela
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
"Lists..."with"Retrieves information about..."in two data sources that incorrectly used mutation-implying language:data_source_github_enterprise_teams.go:"Lists all GitHub enterprise teams..."→"Retrieves information about all GitHub enterprise teams..."data_source_github_enterprise_team_organizations.go:"Lists organizations assigned..."→"Retrieves information about organizations assigned..."Data sources are read-only; their
Descriptionmust use"Gets/Retrieves information about...", not"Manages"or"Lists". Consistent with provider conventions and reviewer feedback on upstream PR #3008.Closes #24