This repository was archived by the owner on Apr 15, 2026. It is now read-only.
fix(scim): use buildTwoPartID for data source IDs#59
Merged
vmvarela merged 1 commit intoenterprise-scimfrom Mar 23, 2026
Merged
fix(scim): use buildTwoPartID for data source IDs#59vmvarela merged 1 commit intoenterprise-scimfrom
vmvarela merged 1 commit intoenterprise-scimfrom
Conversation
Replace fmt.Sprintf("%s/%s", ...) with buildTwoPartID() in both SCIM
data sources, consistent with project convention. Separator changes
from '/' to ':'. Remove unused 'fmt' import from both files.
Closes #53
github-actions
Bot
added
type:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #53
Replace
fmt.Sprintf("%s/%s", ...)withbuildTwoPartID()in both SCIM data sources, consistent with the project convention defined in AGENTS.md.Changes
data_source_github_enterprise_scim_user.gofmt.Sprintf("%s/%s", enterprise, scimUserID)buildTwoPartID(enterprise, scimUserID)data_source_github_enterprise_scim_group.gofmt.Sprintf("%s/%s", enterprise, scimGroupID)buildTwoPartID(enterprise, scimGroupID)Unused
"fmt"import removed from both files.Note
Separator changes from
/to:. As these are data sources (no persistent state for the ID), the risk of state breakage is low.