This repository was archived by the owner on Apr 15, 2026. It is now read-only.
fix(scim): use buildTwoPartID for data source IDs#60
Closed
fix(scim): use buildTwoPartID for data source IDs#60
Conversation
Add util_enterprise_scim.go with helper functions for flattening SCIM user and group data from the GitHub API.
Retrieve information about a single SCIM group by ID. Includes: - Data source implementation - Acceptance tests - Documentation
List all SCIM groups in an enterprise with optional filtering. Includes: - Data source implementation - Acceptance tests - Documentation
Retrieve information about a single SCIM user by ID. Includes: - Data source implementation - Acceptance tests - Documentation
List all SCIM users in an enterprise with optional filtering. Includes: - Data source implementation - Acceptance tests - Documentation
- Register 4 data sources in provider.go: - github_enterprise_scim_group - github_enterprise_scim_groups - github_enterprise_scim_user - github_enterprise_scim_users
Update import paths from go-github/v81 to go-github/v82 to match the current version in upstream/main.
- Rename single-char variables (Rule #29): m→member, e→email, r→role, u→user, g→group - Fix descriptions (Rule #2a): 'Lookup' → 'Retrieves' in all 4 data sources - Fix ValidateFunc → ValidateDiagFunc (Rule #23) in users/groups - Migrate tests from Check to ConfigStateChecks (Rule #31) - Add unit tests for all flatten utility functions (Rule #33) - Add sidebar entries for SCIM data sources in github.erb
Closes #33 - website/docs/d/enterprise.html.markdown - website/docs/r/enterprise_organization.html.markdown The 4 files listed in the issue were already correct. These 2 additional files had the wrong capitalization in the enterprise-scim branch.
Replace fmt.Sprintf("%s/%s", ...) with buildTwoPartID() in both SCIM
data sources, consistent with project convention. Separator changes
from '/' to ':'. Remove unused 'fmt' import from both files.
Closes #53
fix(scim): use buildTwoPartID for data source IDs
github-actions
Bot
added
type:feature
Owner
Author
|
Merged manually via squash commit to master (conflict resolution required). Changes from enterprise-scim are now in master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Replace
fmt.Sprintf("%s/%s", ...)withbuildTwoPartID()in both SCIM data sources. Separator changes from/to:. Unused"fmt"import removed from both files.Tests
Acceptance tests passing:
TestAccGithubEnterpriseSCIMUserDataSource,TestAccGithubEnterpriseSCIMGroupDataSource(4/4).