This repository was archived by the owner on Apr 15, 2026. It is now read-only.
refactor(scim): move enterpriseSCIMMetaSchema() to util_enterprise_scim.go#61
Merged
vmvarela merged 1 commit intoenterprise-scimfrom Mar 23, 2026
Merged
Conversation
…im.go Pure refactor — no functional change. The shared schema helper was defined in data_source_github_enterprise_scim_groups.go but referenced by both groups and users data sources. Moving it to the shared util file makes the codebase easier to navigate. Closes #54
github-actions
Bot
added
type:feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #54
Pure refactor — no functional change.
enterpriseSCIMMetaSchema()was defined indata_source_github_enterprise_scim_groups.gobut referenced by both the groups and users data sources. Moving it toutil_enterprise_scim.go(which already houses shared pagination and flatten utilities for this feature) makes the codebase easier to navigate.Changes
github/util_enterprise_scim.goenterpriseSCIMMetaSchema()+schemaimportgithub/data_source_github_enterprise_scim_groups.goenterpriseSCIMMetaSchema()Verification
go build ./github/...passes cleanly.