feat: support env var values as flags values (#269)

* feat: support env var values as flags values
* docs: added env var support documentation
* test: fixed integration test for env var

Signed-off-by: Diego Alfonso <dalfonso@vmware.com>

Author: odinnordico

.github/workflows/ci.yaml

@@ -79,6 +79,8 @@ jobs:
         - 1.23.5
     env:
       REGISTRY_NAME: registry.local
+      REGISTRY_USERNAME: ruser
+      REGISTRY_PASSWORD: rpass
       BUNDLE: registry.local/integration-test/hellojar:source
       TANZU_CLI_NO_INIT: true
       TANZU_HOME: $HOME/tanzu
@@ -119,7 +121,7 @@ jobs:
         echo "##[group]Install CA"
           # https://ubuntu.com/server/docs/security-trust-store
           sudo apt-get install -y ca-certificates
-          sudo cp ${CERT_DIR}/ca.pem /usr/local/share/ca-certificates/ca.crt
+          # sudo cp ${CERT_DIR}/ca.pem /usr/local/share/ca-certificates/ca.crt
           sudo update-ca-certificates
         echo "##[endgroup]"
         echo "##[group]Generate cert"
@@ -135,11 +137,21 @@ jobs:
         set -o errexit
         set -o nounset
         set -o pipefail
+        # Create password file
+        REGISTRY_HTPWD=$(mktemp -d -t htpwd.XXXX)
+        docker run \
+        --entrypoint htpasswd \
+        httpd:2 -Bbn ${REGISTRY_USERNAME} ${REGISTRY_PASSWORD} > ${REGISTRY_HTPWD}/htpasswd
+        
         # Run a registry.
         docker run -d \
           --restart=always \
           --name local-registry \
           -v ${CERT_DIR}:/certs \
+          -v ${REGISTRY_HTPWD}:/auth \
+          -e "REGISTRY_AUTH=htpasswd" \
+          -e "REGISTRY_AUTH_HTPASSWD_REALM=Registry Realm" \
+          -e REGISTRY_AUTH_HTPASSWD_PATH=/auth/htpasswd \
           -e REGISTRY_HTTP_ADDR=0.0.0.0:443 \
           -e REGISTRY_HTTP_TLS_CERTIFICATE=/certs/server.pem \
           -e REGISTRY_HTTP_TLS_KEY=/certs/server-key.pem \

docs/command-reference/tanzu_apps_workload_apply.md

@@ -80,4 +80,5 @@ tanzu apps workload apply --file workload.yaml
 ### SEE ALSO
 
 * [tanzu apps workload](tanzu_apps_workload.md)	 - Workload lifecycle management
+* [environment variable](../working-with-workloads.md#env-vars) support
 

docs/command-reference/tanzu_apps_workload_create.md

@@ -82,4 +82,5 @@ tanzu apps workload create --file workload.yaml
 ### SEE ALSO
 
 * [tanzu apps workload](tanzu_apps_workload.md)	 - Workload lifecycle management
+* [environment variable](../working-with-workloads.md#env-vars) support
 

docs/commands-details/workload_create_update_apply.md

@@ -631,6 +631,8 @@ The `.tanzuignore` file should contain a list of filepaths to exclude from the i
 ### `--source-image`, `-s`
 Registry path where the local source code will be uploaded as an image.
 
+[environment variable](../working-with-workloads.md#env-vars) supported
+
 <details><summary>Example</summary>
 
 ```bash
@@ -1118,6 +1120,8 @@ spring-pet-clinic-build-1-build-pod[prepare] 2022-06-15T11:28:01.365372427-05:00
 ### `--type`
 Sets the type of the workload by adding the label `apps.tanzu.vmware.com/workload-type`, which is very common to be used as a matcher by supply chains.
 
+[environment variable](../working-with-workloads.md#env-vars) supported
+
 <details><summary>Example</summary>
 
 ```bash

docs/working-with-workloads.md

@@ -43,7 +43,7 @@ Tanzu Application Platform supports creating a workload from an existing local p
 
     - `pet-clinic` is the name of the workload.
     - `--local-path` points to the directory where the source code is located.
-    - `--source-image` is the registry path where the local source code will be uploaded as an image.
+    - `--source-image` is the registry path where the local source code will be uploaded as an image. It can be set by an [environment variable](#env-vars)
 
     **Exclude Files**
     When working with local source code, you can exclude files from the source code to be uploaded within the image by creating a file `.tanzuignore` at the root of the source code. You can find the options available to specify the workload in the command reference for [`workload create`](command-reference/tanzu_apps_workload_create.md), or you can run `tanzu apps workload create --help`.
@@ -118,6 +118,22 @@ tanzu apps workload create petclinic-image --param-yaml maven=$"artifactId:hello
 tanzu apps workload create petclinic-image --param-yaml maven="{"artifactId":"hello-world", "type": "jar", "version": "0.0.1", "groupId": "carto.run"}"
 ```
 
+### <a id="env-vars"></a> Create and Apply environment variables
+
+Developers will provide the same flags/values repeatedly when iterating on their application code.
+Typing or *copy*/*pasting* the flag values for every workload `create`/`apply` adds friction to the developer workflow.
+
+For this reason the apps plugin support the use some environment variables to set those values for the following flags:
+
+- `--type`: `TANZU_APPS_TYPE`
+- `--registry-ca-cert`: `TANZU_APPS_REGISTRY_CA_CERT`
+- `--registry-password`: `TANZU_APPS_REGISTRY_PASSWORD`
+- `--registry-username`: `TANZU_APPS_REGISTRY_USERNAME`
+- `--registry-token`: `TANZU_APPS_REGISTRY_TOKEN`
+- `--source-image`: `TANZU_APPS_SOURCE_IMAGE`
+
+**Note:** Be aware that when set a supported environment value, each apps plugin command will set the flag with the value on the environment variable value
+
 ## <a id='service-binding'></a> Bind a Service to a Workload
 
 Multiple services can be configured for each workload. The cluster supply chain is in charge of provisioning those services.

go.mod

@@ -12,6 +12,7 @@ require (
 	github.com/google/go-cmp v0.5.8
 	github.com/google/go-containerregistry v0.11.0
 	github.com/spf13/cobra v1.5.0
+	github.com/spf13/viper v1.12.0
 	github.com/stern/stern v1.21.0
 	github.com/stretchr/testify v1.8.0
 	github.com/vmware-labs/reconciler-runtime v0.7.1
@@ -30,8 +31,10 @@ require (
 )
 
 require (
-	cloud.google.com/go v0.99.0 // indirect
-	cloud.google.com/go/storage v1.18.2 // indirect
+	cloud.google.com/go v0.102.0 // indirect
+	cloud.google.com/go/compute v1.7.0 // indirect
+	cloud.google.com/go/iam v0.3.0 // indirect
+	cloud.google.com/go/storage v1.22.1 // indirect
 	github.com/Azure/azure-sdk-for-go v66.0.0+incompatible // indirect
 	github.com/Azure/go-autorest v14.2.0+incompatible // indirect
 	github.com/Azure/go-autorest/autorest v0.11.23 // indirect
@@ -62,12 +65,9 @@ require (
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/blang/semver v3.5.1+incompatible // indirect
 	github.com/briandowns/spinner v1.18.0 // indirect
-	github.com/census-instrumentation/opencensus-proto v0.3.0 // indirect
 	github.com/cespare/xxhash/v2 v2.1.2 // indirect
 	github.com/cheggaaa/pb v1.0.29 // indirect
 	github.com/cheggaaa/pb/v3 v3.1.0 // indirect
-	github.com/cncf/udpa/go v0.0.0-20210930031921-04548b0d99d4 // indirect
-	github.com/cncf/xds/go v0.0.0-20211130200136-a8f946100490 // indirect
 	github.com/containerd/stargz-snapshotter/estargz v0.12.0 // indirect
 	github.com/coredns/caddy v1.1.1 // indirect
 	github.com/coredns/corefile-migration v1.0.17 // indirect
@@ -84,11 +84,9 @@ require (
 	github.com/docker/go-units v0.4.0 // indirect
 	github.com/drone/envsubst/v2 v2.0.0-20210730161058-179042472c46 // indirect
 	github.com/emicklei/go-restful v2.9.5+incompatible // indirect
-	github.com/envoyproxy/go-control-plane v0.10.1 // indirect
-	github.com/envoyproxy/protoc-gen-validate v0.6.2 // indirect
 	github.com/evanphx/json-patch v5.6.0+incompatible // indirect
 	github.com/evanphx/json-patch/v5 v5.6.0 // indirect
-	github.com/fsnotify/fsnotify v1.5.1 // indirect
+	github.com/fsnotify/fsnotify v1.5.4 // indirect
 	github.com/ghodss/yaml v1.0.0 // indirect
 	github.com/go-openapi/analysis v0.19.5 // indirect
 	github.com/go-openapi/errors v0.19.2 // indirect
@@ -112,7 +110,9 @@ require (
 	github.com/google/go-querystring v1.1.0 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/google/uuid v1.3.0 // indirect
-	github.com/googleapis/gax-go/v2 v2.1.1 // indirect
+	github.com/googleapis/enterprise-certificate-proxy v0.0.0-20220520183353-fd19c99a87aa // indirect
+	github.com/googleapis/gax-go/v2 v2.4.0 // indirect
+	github.com/googleapis/go-type-adapters v1.0.0 // indirect
 	github.com/hashicorp/go-version v1.4.0 // indirect
 	github.com/hashicorp/hcl v1.0.0 // indirect
 	github.com/huandu/xstrings v1.3.2 // indirect
@@ -130,7 +130,7 @@ require (
 	github.com/klauspost/compress v1.15.8 // indirect
 	github.com/lithammer/dedent v1.1.0 // indirect
 	github.com/logrusorgru/aurora v2.0.3+incompatible // indirect
-	github.com/magiconair/properties v1.8.5 // indirect
+	github.com/magiconair/properties v1.8.6 // indirect
 	github.com/mailru/easyjson v0.7.7 // indirect
 	github.com/mattn/go-colorable v0.1.12 // indirect
 	github.com/mattn/go-isatty v0.0.14 // indirect
@@ -139,7 +139,7 @@ require (
 	github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
 	github.com/mitchellh/copystructure v1.2.0 // indirect
 	github.com/mitchellh/go-homedir v1.1.0 // indirect
-	github.com/mitchellh/mapstructure v1.4.3 // indirect
+	github.com/mitchellh/mapstructure v1.5.0 // indirect
 	github.com/mitchellh/reflectwalk v1.0.2 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
@@ -148,7 +148,8 @@ require (
 	github.com/onsi/gomega v1.19.0 // indirect
 	github.com/opencontainers/go-digest v1.0.0 // indirect
 	github.com/opencontainers/image-spec v1.0.3-0.20220114050600-8b9d41f48198 // indirect
-	github.com/pelletier/go-toml v1.9.4 // indirect
+	github.com/pelletier/go-toml v1.9.5 // indirect
+	github.com/pelletier/go-toml/v2 v2.0.1 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/prometheus/client_golang v1.12.1 // indirect
@@ -159,14 +160,13 @@ require (
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/shopspring/decimal v1.2.0 // indirect
 	github.com/sirupsen/logrus v1.9.0 // indirect
-	github.com/spf13/afero v1.6.0 // indirect
-	github.com/spf13/cast v1.4.1 // indirect
+	github.com/spf13/afero v1.8.2 // indirect
+	github.com/spf13/cast v1.5.0 // indirect
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
-	github.com/spf13/viper v1.10.1 // indirect
 	github.com/stoewer/go-strcase v1.2.0 // indirect
 	github.com/stretchr/objx v0.4.0 // indirect
-	github.com/subosito/gotenv v1.2.0 // indirect
+	github.com/subosito/gotenv v1.3.0 // indirect
 	github.com/valyala/fastjson v1.6.3 // indirect
 	github.com/vbatts/tar-split v0.11.2 // indirect
 	github.com/vdemeester/k8s-pkg-credentialprovider v1.22.4 // indirect
@@ -188,17 +188,17 @@ require (
 	golang.org/x/term v0.0.0-20220411215600-e5f449aeb171 // indirect
 	golang.org/x/text v0.3.7 // indirect
 	golang.org/x/time v0.0.0-20220224211638-0e9765cccd65 // indirect
-	golang.org/x/xerrors v0.0.0-20220517211312-f3a8303e98df // indirect
+	golang.org/x/xerrors v0.0.0-20220609144429-65e65417b02f // indirect
 	gomodules.xyz/jsonpatch/v2 v2.2.0 // indirect
 	gomodules.xyz/jsonpatch/v3 v3.0.1 // indirect
 	gomodules.xyz/orderedmap v0.1.0 // indirect
-	google.golang.org/api v0.63.0 // indirect
+	google.golang.org/api v0.84.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
-	google.golang.org/genproto v0.0.0-20220308174144-ae0e22291548 // indirect
-	google.golang.org/grpc v1.44.0 // indirect
+	google.golang.org/genproto v0.0.0-20220616135557-88e70c0c3a90 // indirect
+	google.golang.org/grpc v1.47.0 // indirect
 	google.golang.org/protobuf v1.28.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
-	gopkg.in/ini.v1 v1.66.2 // indirect
+	gopkg.in/ini.v1 v1.66.4 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	k8s.io/apiserver v0.24.0 // indirect