Use constants for port numbers

Signed-off-by: Kumar Atish <kumar.atish@broadcom.com>

Author: Atish-iaf

pkg/nsx/services/nsxserviceaccount/cluster.go

@@ -33,10 +33,12 @@ import (
 )
 
 const (
-	siteId             = "default"
-	enforcementpointId = "default"
-	PortRestAPI        = "rest-api"
-	PortNSXRPCFwdProxy = "nsx-rpc-fwd-proxy"
+	siteId                = "default"
+	enforcementpointId    = "default"
+	PortRestAPI           = "rest-api"
+	PortNumRestAPI        = 10091
+	PortNSXRPCFwdProxy    = "nsx-rpc-fwd-proxy"
+	PortNumNSXRPCFwdProxy = 10092
 	// #nosec G101: false positive triggered by variable name which includes "secret"
 	SecretSuffix   = "-nsx-cert"
 	SecretCAName   = "ca.crt"
@@ -320,8 +322,8 @@ func (s *NSXServiceAccountService) getProxyEndpoints(ctx context.Context, obj *v
 		return v1alpha1.NSXProxyEndpoint{
 			Addresses: []v1alpha1.NSXProxyEndpointAddress{{IP: "127.0.0.1"}},
 			Ports: []v1alpha1.NSXProxyEndpointPort{
-				{Name: PortRestAPI, Port: 10091, Protocol: v1alpha1.NSXProxyProtocolTCP},
-				{Name: PortNSXRPCFwdProxy, Port: 10092, Protocol: v1alpha1.NSXProxyProtocolTCP},
+				{Name: PortRestAPI, Port: PortNumRestAPI, Protocol: v1alpha1.NSXProxyProtocolTCP},
+				{Name: PortNSXRPCFwdProxy, Port: PortNumNSXRPCFwdProxy, Protocol: v1alpha1.NSXProxyProtocolTCP},
 			},
 		}, nil
 	}

pkg/nsx/services/nsxserviceaccount/cluster_test.go

@@ -669,12 +669,12 @@ func TestNSXServiceAccountService_CreateOrUpdateNSXServiceAccount(t *testing.T)
 						Ports: []v1alpha1.NSXProxyEndpointPort{
 							{
 								Name:     PortRestAPI,
-								Port:     10091,
+								Port:     PortNumRestAPI,
 								Protocol: v1alpha1.NSXProxyProtocolTCP,
 							},
 							{
 								Name:     PortNSXRPCFwdProxy,
-								Port:     10092,
+								Port:     PortNumNSXRPCFwdProxy,
 								Protocol: v1alpha1.NSXProxyProtocolTCP,
 							},
 						},
@@ -2384,12 +2384,12 @@ func TestNSXServiceAccountService_getProxyEndpoints(t *testing.T) {
 				Ports: []v1alpha1.NSXProxyEndpointPort{
 					{
 						Name:     PortRestAPI,
-						Port:     10091,
+						Port:     PortNumRestAPI,
 						Protocol: v1alpha1.NSXProxyProtocolTCP,
 					},
 					{
 						Name:     PortNSXRPCFwdProxy,
-						Port:     10092,
+						Port:     PortNumNSXRPCFwdProxy,
 						Protocol: v1alpha1.NSXProxyProtocolTCP,
 					},
 				},
@@ -2722,13 +2722,13 @@ func TestUpdateProxyEndpointsIfNeeded(t *testing.T) {
 				Ports: []v1alpha1.NSXProxyEndpointPort{
 					{
 						Name:     PortRestAPI,
-						Port:     10091,
+						Port:     PortNumRestAPI,
 						Protocol: v1alpha1.NSXProxyProtocolTCP,
 					},
 					{
 						Name:     PortNSXRPCFwdProxy,
 						Protocol: v1alpha1.NSXProxyProtocolTCP,
-						Port:     10092,
+						Port:     PortNumNSXRPCFwdProxy,
 					},
 				},
 			},