Implement Mixed Mode State Detection#1396
Open
heypnus wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
+ Coverage 76.77% 77.06% +0.29%
==========================================
Files 151 155 +4
Lines 21315 22167 +852
==========================================
+ Hits 16364 17084 +720
- Misses 3782 3878 +96
- Partials 1169 1205 +36
🚀 New features to boost your workflow:
|
heypnus
force-pushed
the
m1
branch
3 times, most recently
from
0fea7b3 to
c0064c0
Compare
yanjunz97
reviewed
Apr 1, 2026
heypnus
force-pushed
the
m1
branch
2 times, most recently
from
0f8b260 to
5af4a3f
Compare
heypnus
force-pushed
the
m1
branch
4 times, most recently
from
6e1cc2d to
c0b5bbb
Compare
yanjunz97
reviewed
Apr 16, 2026
Replace the global boolean cf.CoeConfig.EnableVPCNetwork with namespace-driven mixed-mode state: HasT1Namespaces and HasVPCNamespaces. New module: pkg/config/mixed_mode.go - Checks SupervisorCapabilities CRD for supports_per_namespace_network_providers capability. - If supported: scans namespace annotations `nsx.vmware.com/vpc_network_config` to derive HasVPCNamespaces and HasT1Namespaces. - If not supported (legacy/pre-9.2): falls back to EnableVPCNetwork config flag. This enables NSX Operator to run in mixed mode where both T1 and VPC namespaces coexist, as required for VDS->VPC and T1->VPC migration. NOTE: This patch only ensures that the existing pure T1 or pure VPC envs preserve existing behaviours. The full functionality will be implemented in the follow-up patches. Testing done: 1. T1 pipeline with ID 5695 2. VPC pipeline with ID 17501
Contributor
Author
|
/e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the global boolean cf.CoeConfig.EnableVPCNetwork with
namespace-driven mixed-mode state: HasT1Namespaces and
HasVPCNamespaces.
New module: pkg/config/mixed_mode.go
capability.
nsx.vmware.com/vpc_network_configto derive HasVPCNamespaces and HasT1Namespaces.
config flag.
This enables NSX Operator to run in mixed mode where both T1 and VPC
namespaces coexist, as required for VDS->VPC and T1->VPC migration.
NOTE: This patch only ensures that the existing pure T1 or pure VPC envs
preserve existing behaviours. The full functionality will be
implemented in the follow-up patches.
Testing done: