Skip to content

Add inventory-based NSX groups for SecurityPolicy#1408

Open
wenqiq wants to merge 2 commits into
vmware-tanzu:mainfrom
wenqiq:topic/wenqi/securityPolicy-group
Open

Add inventory-based NSX groups for SecurityPolicy#1408
wenqiq wants to merge 2 commits into
vmware-tanzu:mainfrom
wenqiq:topic/wenqi/securityPolicy-group

Conversation

@wenqiq
Copy link
Copy Markdown
Contributor

@wenqiq wenqiq commented Apr 14, 2026

No description provided.

@wenqiq wenqiq force-pushed the topic/wenqi/securityPolicy-group branch from 96f3d66 to 2d4bf2c Compare April 15, 2026 02:22
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 0.74257% with 401 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.39%. Comparing base (7b8f64b) to head (840510f).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...g/nsx/services/securitypolicy/builder_namespace.go 0.75% 396 Missing ⚠️
pkg/nsx/cluster.go 0.00% 3 Missing ⚠️
pkg/nsx/services/securitypolicy/builder.go 0.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.74%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1408      +/-   ##
==========================================
- Coverage   76.78%   75.39%   -1.40%     
==========================================
  Files         152      153       +1     
  Lines       21585    21989     +404     
==========================================
+ Hits        16575    16578       +3     
- Misses       3824     4224     +400     
- Partials     1186     1187       +1     
Flag Coverage Δ
unit-tests 75.39% <0.74%> (-1.40%) ⬇️
Files with missing lines Coverage Δ
pkg/nsx/client.go 94.09% <ø> (ø)
pkg/nsx/services/common/types.go 100.00% <ø> (ø)
pkg/nsx/services/securitypolicy/builder.go 87.58% <0.00%> (-0.13%) ⬇️
pkg/nsx/cluster.go 58.02% <0.00%> (-0.50%) ⬇️
...g/nsx/services/securitypolicy/builder_namespace.go 0.75% <0.75%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wenqiq wenqiq force-pushed the topic/wenqi/securityPolicy-group branch from 2d4bf2c to ced0cee Compare April 21, 2026 06:36
Signed-off-by: Wenqi Qiu <wenqi.qiu@broadcom.com>
@wenqiq wenqiq force-pushed the topic/wenqi/securityPolicy-group branch from ced0cee to c315fd7 Compare April 21, 2026 07:10
@wenqiq wenqiq marked this pull request as ready for review April 21, 2026 07:11
Signed-off-by: Wenqi Qiu <wenqi.qiu@broadcom.com>
@wenqiq wenqiq force-pushed the topic/wenqi/securityPolicy-group branch from 1941be2 to 840510f Compare April 21, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants