nsxserviceaccount: backoff NSX calls after CCP connection capacity error 610139#1420
Open
liu4480 wants to merge 1 commit into
Open
nsxserviceaccount: backoff NSX calls after CCP connection capacity error 610139#1420liu4480 wants to merge 1 commit into
liu4480 wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1420 +/- ##
==========================================
+ Coverage 75.51% 77.05% +1.53%
==========================================
Files 154 155 +1
Lines 26420 22034 -4386
==========================================
- Hits 19951 16978 -2973
+ Misses 5265 3855 -1410
+ Partials 1204 1201 -3
🚀 New features to boost your workflow:
|
liu4480
force-pushed
the
topic/bl018815/nsxserviceaccount-ratelimit
branch
from
e91af3f to
586cedb
Compare
…ror 610139 When ClusterControlPlanesClient.Update returns NSX error 610139 (connection capacity full), record a global timestamp. While a 5-minute window from that timestamp is still in effect, NSXServiceAccount reconcile requeues without calling NSX. After the window expires, reconcile proceeds normally; a successful CCP update clears the timestamp, and another 610139 refreshes it. Add IsCCPConnectionCapacityFullError in pkg/nsx/util. Fix controller tests that assumed deletion state on objects returned from the fake client.
liu4480
force-pushed
the
topic/bl018815/nsxserviceaccount-ratelimit
branch
from
586cedb to
a871b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ClusterControlPlanesClient.Update returns NSX error 610139 (connection
capacity full), record a global timestamp. While a 5-minute window from that
timestamp is still in effect, NSXServiceAccount reconcile requeues without
calling NSX. After the window expires, reconcile proceeds normally; a
successful CCP update clears the timestamp, and another 610139 refreshes it.
Add IsCCPConnectionCapacityFullError in pkg/nsx/util. Fix controller tests that
assumed deletion state on objects returned from the fake client.