feat(dns): NSX DNS record service and zone validation#1423
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1423 +/- ##
==========================================
+ Coverage 77.00% 77.62% +0.61%
==========================================
Files 156 169 +13
Lines 22205 23312 +1107
==========================================
+ Hits 17100 18097 +997
- Misses 3892 3954 +62
- Partials 1213 1261 +48
🚀 New features to boost your workflow:
|
wenyingd
force-pushed
the
dns-only
branch
8 times, most recently
from
May 12, 2026 02:16
0825801 to
7f460a0
Compare
wenyingd
force-pushed
the
dns-only
branch
4 times, most recently
from
May 14, 2026 11:40
944694e to
d5459d9
Compare
TaoZou1
previously approved these changes
May 15, 2026
Contributor
|
Please add enough UT later. |
wenyingd
force-pushed
the
dns-only
branch
2 times, most recently
from
May 15, 2026 06:01
ebdc0d8 to
236e7bf
Compare
wenyingd
force-pushed
the
dns-only
branch
2 times, most recently
from
May 15, 2026 07:55
2593094 to
c882eb5
Compare
TaoZou1
previously approved these changes
May 15, 2026
Contributor
Author
|
/e2e |
Contributor
|
/e2e |
wenyingd
force-pushed
the
dns-only
branch
2 times, most recently
from
May 22, 2026 11:20
54552ba to
c5a41f0
Compare
Contributor
Author
heypnus
reviewed
May 25, 2026
- Implement DNSRecordService for NSX ProjectDnsRecord CRUD operations - Validate hostnames against VPCNetworkConfiguration allowed DNS zones - Wrap hostname-mismatch error as DNSZoneValidationError for accurate DNSRecordReady condition reporting - Remove the realization state check before NSX API is ready
TaoZou1
approved these changes
May 27, 2026
heypnus
reviewed
May 27, 2026
Contributor
Author
|
/e2e |
heypnus
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNSRecordReady condition reporting
Testing Done: