feat(gateway): configure DNS records for Gateway API resources #1427
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* Copyright © 2026 Broadcom, Inc. All Rights Reserved. | ||
| SPDX-License-Identifier: Apache-2.0 */ | ||
|
|
||
| package gateway | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/types" | ||
|
|
||
| "github.com/vmware-tanzu/nsx-operator/pkg/nsx/services/dns" | ||
| extdns "github.com/vmware-tanzu/nsx-operator/pkg/third_party/externaldns/endpoint" | ||
| ) | ||
|
|
||
| // Route DNS: hostnames + ipCache → extdns.Endpoint. | ||
| // Gateway annotation-hostname DNS (collectGatewayEndpointsByAnnotation / buildEndpointsFromAnnotations) | ||
| // was moved to dns-networkinfo-hostname to separate the hostname-conflict-resolution feature. | ||
|
|
||
| type parentGatewayMatch struct { | ||
| nn types.NamespacedName | ||
| filter string | ||
| ips extdns.Targets | ||
| } | ||
|
|
||
| func mergeTargetsUnion(a, b extdns.Targets) extdns.Targets { | ||
| return extdns.NewTargets(append(append([]string(nil), a...), b...)...) | ||
| } | ||
|
|
||
| // buildRouteDNSMergedEndpoints builds owner-scoped Route DNS rows (Gateway or ListenerSet→root Gateway, same rules as aggregation). | ||
| func (a routeReconcilerAdapter[PT, T]) buildRouteDNSMergedEndpoints(route PT) (*dns.AggregatedDNSEndpoints, map[string]string, error) { | ||
|
There was a problem hiding this comment. Where's the
Contributor
Author
There was a problem hiding this comment. do you mean move the existing code in this file to |
||
| owner := route.GetResourceRef() | ||
| eps, allowed, err := a.reconciler.buildRouteDNSEndpointsForAggregation(route.GetNamespace(), owner, route.GetParentRefs(), route.GetRouteParentStatus(), route.GetObjectMeta(), route.GetSpecHostnames()) | ||
| if err != nil || len(eps) == 0 { | ||
| return nil, allowed, err | ||
| } | ||
| return dns.NewOwnerScopedAggregatedRouteDNS(owner, eps), allowed, nil | ||
| } | ||
|
|
||
| // buildEndpoints appends extdns endpoints per hostname; sets EndpointLabelParentGateway to gatewayLabel (comma-separated if merged). | ||
| func buildEndpoints(out *[]*extdns.Endpoint, hostnames []string, targets extdns.Targets, parentGatewayLabel string) { | ||
|
There was a problem hiding this comment. Curious why this func follows an output param pattern while most everything else follows returning vals.
Contributor
Author
There was a problem hiding this comment. It is actually to append the generated Endpoints to an existing slice, the caller is within a for-loop. |
||
| ttl := extdns.TTL(0) | ||
| for _, h := range hostnames { | ||
| if h == "" { | ||
| continue | ||
| } | ||
| for _, ep := range extdns.EndpointsForHostname(h, targets, ttl) { | ||
| if ep == nil { | ||
| continue | ||
| } | ||
| if parentGatewayLabel != "" { | ||
| ep.WithLabel(dns.EndpointLabelParentGateway, parentGatewayLabel) | ||
| } | ||
| *out = append(*out, ep) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the nil val needed? Won't this add a literal
nilentry in?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[]string(nil)equals to the belowvar s []string, but we don't need to introduce a dedicated temporary variablesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, makes sense. Bit tricky to read.